Bug fix for reading namelist section atmos_model_nml for nests#263
Merged
Conversation
…and ccpp-framework for code review and testing
…after atmosphere_init so that nests work correctly
This was referenced Mar 27, 2021
climbfuji
force-pushed
the
bugfix_nests_namelist
branch
from
b0c1d9b to
1401beb
Compare
junwang-noaa
approved these changes
Apr 9, 2021
Collaborator
|
@DusanJovic-NOAA Can you review the code? |
DusanJovic-NOAA
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See PR NOAA-GFDL/GFDL_atmos_cubed_sphere#86 for a detailed description of the issue and the proposed solution (and the reasons for this solution).
The associated changes in fv3atm are (be sure to check the GFDL_atmos_cubed_sphere PR to understand why):
Issue(s) addressed
Fixes #264.
Testing
See ufs-community/ufs-weather-model#488
Dependencies
NOAA-GFDL/GFDL_atmos_cubed_sphere#86
#263
ufs-community/ufs-weather-model#488