Reduce goto in ufs-weather-model: ccpp/physics

[NickSzapiro-NOAA]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

EE2 standards include "Good programming practices must be followed to improve readability. For example, structured control must be used instead of GO TO statements, and code must be well documented."

Here we replace several goto/go to usages and keep current answers (as tested on ursa and wcoss2)

Commit Message:

* UFSWM - Reduce goto in UFSATM
  * UFSATM - Reduce goto in UFSATM
    * ccpp-physics - Reduce goto in ccpp/physics

Priority:

• Normal

Git Tracking

UFSWM:

• Part of Remove goto statements from GFS package NOAA-EMC/GFS#19

Sub component Pull Requests:

• UFSATM: Reduce goto in UFSATM: ccpp/physics NOAA-EMC/ufsatm#1084
  • ccpp-physics: Reduce goto in ccpp-physics ccpp-physics#367

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update required.
  • Relevant updates are included with this PR.
  • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
• Documentation update NOT required.
  • Explanation:

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Adds New Tests/Baselines.
• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[NickSzapiro-NOAA]

Here is a 1-liner to get a quick summary of code goto (not in comments) in this branch:
find . -type f -name "*.[fF]*" -print0 | xargs -0 grep -inP '^(?![Cc*])[^!]*\bgo\s*to\b'
with subdirectory counts of

• AQM: 957
• UFSATM/FV3: 107
• UFSATM/ccpp/physics: 61
• UFSATM/mpas: 119
• HYCOM: 157
• CDEPS: 2
• stochastic_physics: 53
• WW3/regtests: 36
• MOM6: 1

[NickSzapiro-NOAA]

Since not urgent, undoing the UPP changes until later (NOAA-EMC/UPP#1482)

[gspetro-NOAA]

Merged via #3169