Skip to content

Bugfix for GHA warnings/remarks check#3149

Closed
gspetro-NOAA wants to merge 3 commits into
ufs-community:developfrom
gspetro-NOAA:gha-log-check2
Closed

Bugfix for GHA warnings/remarks check#3149
gspetro-NOAA wants to merge 3 commits into
ufs-community:developfrom
gspetro-NOAA:gha-log-check2

Conversation

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA gspetro-NOAA commented Mar 17, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers. N/A
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc. N/A
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR ensures that the warnings/remarks check on GHA does not fail for new tests and picks up cases where there are only warnings or remarks (but not both).

It was tested locally on Denise's PR #3142 to ensure that it solved the problem identified in that PR. I performed additional local testing to ensure the capture of compiles w/only warnings or only remarks when I noticed those cases were missing while testing my fix.

Commit Message:

* UFSWM - Bugfix for GHA warnings/remarks check

Priority:

  • Critical Bugfix: Reason
  • High: Bugfix to faciliate CM duties
  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: CI only

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@github-project-automation github-project-automation Bot moved this to Evaluating in PRs to Process Mar 17, 2026
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review March 17, 2026 14:00
gspetro-NOAA pushed a commit that referenced this pull request Mar 20, 2026
…/remarks check (#3149) (#3114)

* UFSWM - Bugfix for GHA warnings/remarks check
* UFSWM - Hash update for ccpp-physics
  * UFSATM - Hash update for ccpp-physics
    * ccpp-physics - Bugfixes to SLC checks, post-LIAU
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator Author

Merged via PR #3114

@gspetro-NOAA gspetro-NOAA deleted the gha-log-check2 branch March 20, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug in GHA warnings/remarks check

1 participant