Update ufsatm hash for ccpp-physics update // Bugfix for GHA warnings/remarks check (#3149)

[ClaraDraper-NOAA]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives).
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

Description:

#3114

Hash update to pick up ccpp-physics PR ufs-community/ccpp-physics#339

#3149

This PR ensures that the warnings/remarks check on GHA does not fail for new tests and picks up cases where there are only warnings or remarks (but not both).

It was tested locally on Denise's PR #3142 to ensure that it solved the problem identified in that PR. I performed additional local testing to ensure the capture of compiles w/only warnings or only remarks when I noticed those cases were missing while testing my fix.

Commit Message:

* UFSWM - Bugfix for GHA warnings/remarks check
* UFSWM - Hash update for ccpp-physics
  * UFSATM - Hash update for ccpp-physics
    * ccpp-physics - Bugfixes to SLC checks, post-LIAU

Priority:

• Normal

Git Tracking

• Closes CCPP Issue 338
• Closes Bug in GHA warnings/remarks check #3148

Sub component Pull Requests:

• UFSATM: Update ccpp/physics hash. NOAA-EMC/ufsatm#1072
  • ccpp-physics: Bugfixes to SLC checks, post-LIAU ccpp-physics#339

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update NOT required.
  • Explanation: simple bug fix.

---

Regression Test Changes (Please commit test_changes.list):

• PR Updates/Changes Baselines.
• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[ClaraDraper-NOAA]

Will update when tests are complete.

[gspetro-NOAA]

@ClaraDraper-NOAA Just wanted to check in--have you had a chance to run the RTs?

[ClaraDraper-NOAA]

@ClaraDraper-NOAA Just wanted to check in--have you had a chance to run the RTs?

I'm on leave today. They hadn't finished when I left, but I'll check when I'm back tomorrow.

[gspetro-NOAA]

@rhaesung @ClaraDraper-NOAA Just wanted to check in and see how you're doing on troubleshooting this PR. I haven't seen any logs added, but I know there was also a test passing that should have had baseline changes. Just wanted to confirm whether you're still troubleshooting that or whether this PR is ready to go (in which case, RhaeSung can push his logs & test_changes.list).

[ClaraDraper-NOAA]

@rhaesung @ClaraDraper-NOAA Just wanted to check in and see how you're doing on troubleshooting this PR. I haven't seen any logs added, but I know there was also a test passing that should have had baseline changes. Just wanted to confirm whether you're still troubleshooting that or whether this PR is ready to go (in which case, RhaeSung can push his logs & test_changes.list).

From our emails: I am still unable to get rt.sh to write the summary file, so Rhae Sung was running them. When he ran them a test passed which should have failed (the output from the control_c48_lnd_iau test should be different). I have not heard more about that - Rhae Sung, can you perhaps point me to your clone and output?

[rhaesung]

@rhaesung @ClaraDraper-NOAA Just wanted to check in and see how you're doing on troubleshooting this PR. I haven't seen any logs added, but I know there was also a test passing that should have had baseline changes. Just wanted to confirm whether you're still troubleshooting that or whether this PR is ready to go (in which case, RhaeSung can push his logs & test_changes.list).

From our emails: I am still unable to get rt.sh to write the summary file, so Rhae Sung was running them. When he ran them a test passed which should have failed (the output from the control_c48_lnd_iau test should be different). I have not heard more about that - Rhae Sung, can you perhaps point me to your clone and output?

@ClaraDraper-NOAA /scratch4/NCEPDEV/global/RhaeSung.Kim/clara/ufs-weather-model/tests

[gspetro-NOAA]

From our emails: I am still unable to get rt.sh to write the summary file, so Rhae Sung was running them. When he ran them a test passed which should have failed (the output from the control_c48_lnd_iau test should be different). I have not heard more about that - Rhae Sung, can you perhaps point me to your clone and output?

Thanks! That's good to know--I was trying to see if there had been any movement since we last corresponded, but it sounds like we'll have to wait on more info from @rhaesung . Once the test that should have failed is troubleshooted, we can process this PR. I may try to run just that test on Ursa and see what happens.

[rhaesung]

@gspetro-NOAA control_c48_lnd_iau (which failed) is currently in test_changes.list. If we remove the timed-out control_p8_ugwpv1_tempo_aerosol_hail Intel test and @ClaraDraper-NOAA or you push the logs and updated test_changes.list, this PR should be ready to go.

[ClaraDraper-NOAA]

@gspetro-NOAA control_c48_lnd_iau (which failed) is currently in test_changes.list. If we remove the timed-out control_p8_ugwpv1_tempo_aerosol_hail Intel test and @ClaraDraper-NOAA or you push the logs and updated test_changes.list, this PR should be ready to go.

Great - that's the job that should fail! I don't have the test_changes or log file, so can't push them (unless I copy them from you?)

[rhaesung]

@gspetro-NOAA control_c48_lnd_iau (which failed) is currently in test_changes.list. If we remove the timed-out control_p8_ugwpv1_tempo_aerosol_hail Intel test and @ClaraDraper-NOAA or you push the logs and updated test_changes.list, this PR should be ready to go.

Great - that's the job that should fail! I don't have the test_changes or log file, so can't push them (unless I copy them from you?)

Yes, please feel free to copy them and push the logs and test_changes.list.

[gspetro-NOAA]

@ClaraDraper-NOAA @rhaesung Thanks for your work on this! I just pushed the logs & test_changes.list and will go about requesting reviews now. We can probably schedule this PR for tomorrow or Wednesday depending on how testing going on the upcoming PR.

[gspetro-NOAA]

@ClaraDraper-NOAA or @rhaesung Could you sync w/develop? Once the hashes are updated and reviews are in, we should be good to go.

[ClaraDraper-NOAA]

@ClaraDraper-NOAA or @rhaesung Could you sync w/develop? Once the hashes are updated and reviews are in, we should be good to go.

doing it now.

[gspetro-NOAA]

@ClaraDraper-NOAA We will begin processing your PR now, and we will combine in PR #3149 . I can take care of that--you shouldn't have to do anything--but I just wanted to give you a heads up.

[gspetro-NOAA]

Testing has completed successfully on all systems! Leaving a note in sub-PRs.