Skip to content

Update FV3 hash to include UPP ss192/Ursa updates#2814

Merged
jkbk2004 merged 16 commits into
ufs-community:developfrom
dpsarmie:feature/update_upp_ss192-ursa
Jul 24, 2025
Merged

Update FV3 hash to include UPP ss192/Ursa updates#2814
jkbk2004 merged 16 commits into
ufs-community:developfrom
dpsarmie:feature/update_upp_ss192-ursa

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented Jul 18, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR will update the FV3 hash to include an updated UPP hash. The UPP updates needed are to support Ursa and ss192 (https://github.com/NOAA-EMC/UPP/tree/8f6caa9). The hash update will be the only change in this PR.
Updating the hash will bring in about 25 other older PRs from UPP. The hash this will update to is https://github.com/NOAA-EMC/UPP/tree/8f6caa9. This will be done to allow GW to update their systems to work on Ursa and to work with ss192.

Commit Message:

* UFSWM - Update to FV3 hash containing UPP support for Ursa
  * FV3 - Update UPP hash to include changes for Ursa support

Priority:

  • High: GFS v17 and Global workflow requirement

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • No documentation update is required for this PR because this is just a submodule hash update.

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.
cpld_control_gefs intel
cpld_restart_gefs intel
cpld_dcp_gefs intel
cpld_control_gfsv17 intel
cpld_control_gfsv17_iau intel
cpld_restart_gfsv17 intel
cpld_mpi_gfsv17 intel
cpld_control_gfsv17_nowav_iau intel
cpld_restart_gfsv17_nowav_iau intel
cpld_control_sfs intel
cpld_debug_gfsv17 intel
control_flake intel
control_CubedSphereGrid_parallel intel
control_latlon intel
control_wrtGauss_netcdf_parallel intel
control_c192 intel
control_c384 intel
control_c384gdas intel
control_stochy intel
control_stochy_restart intel
control_lndp intel
control_iovr4 intel
control_iovr4_gfdlmpv3 intel
control_iovr5 intel
control_p8 intel
control_p8.v2.sfc intel
control_p8_ugwpv1 intel
control_p8_ugwpv1_tempo intel
control_p8_ugwpv1_tempo_aerosol intel
control_p8_ugwpv1_tempo_aerosol_hail intel
control_restart_p8 intel
control_noqr_p8 intel
control_restart_noqr_p8 intel
control_decomp_p8 intel
control_2threads_p8 intel
control_p8_lndp intel
control_p8_rrtmgp intel
control_p8_mynn intel
merra2_thompson intel
regional_control intel
regional_restart intel
regional_decomp intel
regional_2threads intel
regional_2dwrtdecomp intel
regional_wofs intel
rap_control intel
regional_spp_sppt_shum_skeb intel
rap_decomp intel
rap_2threads intel
rap_restart intel
rap_sfcdiff intel
rap_sfcdiff_decomp intel
rap_sfcdiff_restart intel
hrrr_control intel
hrrr_control_decomp intel
hrrr_control_2threads intel
hrrr_control_restart intel
rrfs_v1beta intel
rrfs_v1nssl intel
rrfs_v1nssl_nohailnoccn intel
control_csawmg intel
control_ras intel
control_p8_faster intel
regional_control_faster intel
control_diag_debug intel
rap_diag_debug intel
regional_spp_sppt_shum_skeb_dyn32_phy32 intel
rap_control_dyn32_phy32 intel
hrrr_control_dyn32_phy32 intel
rap_2threads_dyn32_phy32 intel
hrrr_control_2threads_dyn32_phy32 intel
hrrr_control_decomp_dyn32_phy32 intel
rap_restart_dyn32_phy32 intel
hrrr_control_restart_dyn32_phy32 intel
rap_control_dyn64_phy32 intel
hafs_regional_atm intel
hafs_regional_atm_gfdlmpv3 intel
hafs_global_multiple_4nests_atm intel
hafs_regional_specified_moving_1nest_atm intel
atmaero_control_p8 intel
atmaero_control_p8_rad intel
atmaero_control_p8_rad_micro intel
control_stochy gnu
control_ras gnu
control_p8 gnu
control_p8_ugwpv1 gnu
control_flake gnu
rap_control gnu
rap_decomp gnu
rap_2threads gnu
rap_restart gnu
rap_sfcdiff gnu
rap_sfcdiff_decomp gnu
rap_sfcdiff_restart gnu
hrrr_control gnu
hrrr_control_noqr gnu
hrrr_control_2threads gnu
hrrr_control_decomp gnu
hrrr_control_restart gnu
hrrr_control_restart_noqr gnu
rrfs_v1beta gnu
control_csawmg gnu
control_diag_debug gnu
rap_diag_debug gnu
rap_control_dyn32_phy32 gnu
hrrr_control_dyn32_phy32 gnu
rap_2threads_dyn32_phy32 gnu
hrrr_control_2threads_dyn32_phy32 gnu
hrrr_control_decomp_dyn32_phy32 gnu
rap_restart_dyn32_phy32 gnu
hrrr_control_restart_dyn32_phy32 gnu
rap_control_dyn64_phy32 gnu
cpld_control_pdlib_p8 gnu

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@JessicaMeixner-NOAA JessicaMeixner-NOAA moved this to In Progress in GFS v17 Jul 18, 2025
@dpsarmie dpsarmie self-assigned this Jul 18, 2025
@dpsarmie dpsarmie added the Baseline Updates Current baselines will be updated. label Jul 18, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

@dpsarmie can you sync up branches?

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

@dpsarmie can you sync up branches?

Ok, should be good for RT testing.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the In Testing The PR that is currently in testing stages label Jul 21, 2025
@jkbk2004 jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jul 22, 2025
@dpsarmie dpsarmie moved this from In Progress to Ready to commit in UFS infrastructure development Q4FY25 Jul 22, 2025
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

on WCOSS2 I'm getting the merra2_hf_thompson_intel test to change baselines in the GFSPRS.GrbF(21/24) files only. This test is not on the list for changing baselines. I'm curious if this is just WCOSS2 @FernandoAndrade-NOAA ?

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

dpsarmie commented Jul 22, 2025

That test was added with yesterday's PR (#2813) and I didn't redo the RT suite (or at least that test) before testing got underway. It's possible that the baselines for that test also need to be updated. I'll check on my end to make sure.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

on WCOSS2 I'm getting the merra2_hf_thompson_intel test to change baselines in the GFSPRS.GrbF(21/24) files only. This test is not on the list for changing baselines. I'm curious if this is just WCOSS2 @FernandoAndrade-NOAA ?

I'm still running Hera and Ursa on my side, but I haven't seen that test fail at this time.

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

on WCOSS2 I'm getting the merra2_hf_thompson_intel test to change baselines in the GFSPRS.GrbF(21/24) files only. This test is not on the list for changing baselines. I'm curious if this is just WCOSS2 @FernandoAndrade-NOAA ?

Also did the single test on Ursa and it passed, so I'm now confused.

PASS -- COMPILE 'atm_dyn32_intel' [08:10, 06:37] ( 500 remarks )
PASS -- TEST 'merra2_hf_thompson_intel' [05:23, 03:42](2556 MB)

@dpsarmie dpsarmie mentioned this pull request Jul 22, 2025
14 tasks
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

I don't know why it needed new baselines. All good now though. If we don't see this on other machines, I'm not sure we'll need to put it on the test_changes.list. I wonder if maybe the baseline copy for unchanged tests didn't go quite right. I'll keep that in mind moving forward.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

Forgive the large amount of failures in the initial run of my RT logs - user error, I could have sworn I saw the large test_changes.list before starting, but it seems I started before that commit.

@WenMeng-NOAA
Copy link
Copy Markdown
Contributor

I don't know why it needed new baselines. All good now though. If we don't see this on other machines, I'm not sure we'll need to put it on the test_changes.list. I wonder if maybe the baseline copy for unchanged tests didn't go quite right. I'll keep that in mind moving forward.

@BrianCurtis-NOAA The recent commits for source code updates in UPP repos. have caused baselines changes in upp output.

@jkbk2004 jkbk2004 removed the In Testing The PR that is currently in testing stages label Jul 24, 2025
@jkbk2004
Copy link
Copy Markdown
Collaborator

All tests are done. We can start merging process.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@dpsarmie new fv3 hash is NOAA-EMC/ufsatm@e5b040c

@dpsarmie
Copy link
Copy Markdown
Collaborator Author

Done, should be good for final checks.

@jkbk2004
Copy link
Copy Markdown
Collaborator

For a few weeks, we used to see "jq: error (at :1): Cannot index string with string "head". We will keep checking if we need to update repo check script.

@jkbk2004 jkbk2004 merged commit e39a250 into ufs-community:develop Jul 24, 2025
5 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to commit to Done in UFS infrastructure development Q4FY25 Jul 24, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GFS v17 Jul 24, 2025
@dpsarmie dpsarmie deleted the feature/update_upp_ss192-ursa branch July 31, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Update FV3/UPP hash to include spack-stack 1.9.2 and Ursa support

6 participants