Third reconciliation PR from production/RRFS.v1

[grantfirl]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This is mainly work from @AndersJensen-NOAA. This PR is identical to #2161, but targets develop instead of the RRFSv1 release branch.

This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.

This PR includes:

The addition of parameterized kind: REAL -> real(kind_phys)
Consistent indentation
Removal of GOTO statements
Add physical constant metadata needed by Thompson MP

Commit Message:

* UFSWM - Thompson-Eidhammer microphysics code formatting
  * FV3 - Thompson-Eidhammer microphysics code formatting
    * ccpp-physics - Thompson-Eidhammer microphysics code formatting

Priority:

• High: Needed for SRW App

Git Tracking

UFSWM:

• None

Sub component Pull Requests:

• FV3: Third reconciliation PR from production/RRFS.v1 NOAA-EMC/ufsatm#882
  • ccpp-physics: Third reconciliation PR from production/RRFS.v1 ccpp-physics#229

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Updates/Changes Baselines.

All tests that use Thompson MP will have non bit-for-bit results due to high significant digit changes in physical constants. There is no substantial change in results as tested by @AndersJensen-NOAA in #2161.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[jkbk2004]

@grantfirl can you sync up branch? we can start working on this pr.

[grantfirl]

@grantfirl can you sync up branch? we can start working on this pr.

@jkbk2004 OK, should be good to go.

[FernandoAndrade-NOAA]

Changes also occurred in intelllvm cases + control_c48_lnd_iau_intel across Hera, Gaea, and Jet on my side. The same changes are likely for Orion and Hercules as well. Recreating baselines for those cases now.

[BrianCurtis-NOAA]

I would like to reiterate my request that someone from EMC needs to review all PR's before merge. I was in the middle of my review when it was merged.

[jkbk2004]

All code changes are pretty much at physics level and all approved ok at sub components.