Third reconciliation PR from production/RRFS.v1#229
Merged
Conversation
… into thompson_refactor
…nd it will be consistent with convective precipitation"
…entrations.F90 due to passing in PI as variable
[production/RRFS.v1] physics updates for RRFS.v1 code freeze
…_alloc_RRFS [production/RRFS.v1] Fix 'check all' with 0-size allocations
3 tasks
grantfirl
requested review from
AndersJensen-NOAA,
Qingfu-Liu,
RuiyuSun,
dustinswales,
gthompsnWRF and
rhaesung
as code owners
14 tasks
rhaesung
approved these changes
Nov 14, 2024
dustinswales
approved these changes
Nov 14, 2024
climbfuji
approved these changes
Nov 15, 2024
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Please fix the trailing whitespace, other than that good to go.
|
test are all done at ufs-community/ufs-weather-model#2482. @grantfirl @dustinswales @rhaesung can you merge this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is the same as #179, but targeting ufs/dev.
This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.
This PR includes:
This is expected to change results for any RTs that use Thompson MP because of point 4.