Skip to content

New gnv1_nested regression test#2284

Closed
SamuelTrahanNOAA wants to merge 19 commits into
ufs-community:developfrom
SamuelTrahanNOAA:new-gnv1-regtest
Closed

New gnv1_nested regression test#2284
SamuelTrahanNOAA wants to merge 19 commits into
ufs-community:developfrom
SamuelTrahanNOAA:new-gnv1-regtest

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented May 15, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • N/A - No subcomponent changes. All sub component pull requests have been reviewed by their code managers.
  • N/A - Change is at ufs-weather-model level only, and only affects one test. To avoid wasting resources, I've skipped all other tests. Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • N/A - See above Commit 'test_changes.list' from previous step

Description:

This draft PR replaces the gnv1_nested regression test with a new one that uses the Water in the West domain at C96 resolution. It uses input.nml and model_configure templates which are compatible with the global workflow.

IMPORTANT: When running the new regression test, you must use its new input data.

  • INPUTDATA_ROOT=/scratch2/BMC/wrfruc/Samuel.Trahan/westwater/regtest-C96-guoqing/RT/NEMSfv3gfs/input-data-20240501

  • NOTE TO SELF: Need variables in &surf_map_nml to support the global-workflow. Defaults can be found here: FV3/atmos_cubed_sphere/tools/fv_surf_map.F90

Commit Message:

* UFSWM - new gnv1_nested regression test with Water in the West domain at C96 resolution using templates compatible with global-workflow

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None.

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Only the gnv1_nested regression test is affected, so I haven't run the full regression test suite.

Input data Changes:

  • New input data.

Input data is here:

HERA: /scratch2/BMC/wrfruc/Samuel.Trahan/westwater/regtest-C96-guoqing/RT/NEMSfv3gfs/input-data-20240501

The only new files are in these subdirectories:

  • FV3_input_data/INPUT_L127_nested/ - INPUT/ directory for gnv1_nested test
  • FV3_fix_tiled/C96-nested - Tiled static files for rotated globe and its nest

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

1. Remove duplicate variables.
2. Disable progsigma since the model disables it internally anyway.
   (Due to resolution)
3. Add some _NEST02 variables
4. Enable some gravity wave diagnostics
5. Write restart at time 1 and validate output at time 2. This way we can reduce the run length to 2 hours
6. Increase the run length to 24 hours, with hourly output, for debugging. Should shorten run length before merge.
…e runtime to 3 hours now that debugging is done
@SamuelTrahanNOAA SamuelTrahanNOAA marked this pull request as ready for review May 29, 2024 19:13
@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

SamuelTrahanNOAA commented May 29, 2024

This PR was a draft for a while due to model instability. After much experimenting and digging, I found this was the problem:

full_zs_filter = .true.

It must be:

full_zs_filter = .false.

With that change, the new test is stable and we can move forward with the PR.

I am not running the full regression test suite because the change is confined to one test.

Comment thread tests/default_vars.sh
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN
@guoqing-noaa
Copy link
Copy Markdown

@SamuelTrahanNOAA Thanks for the quick responses!
I was comparing your template with a global workflow run and would like to ensure that we don't bring any unnecessary HAFS settings into the global nest runs. Do you want me to continue and go through all the namelist parameters in the template?

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

@SamuelTrahanNOAA Thanks for the quick responses! I was comparing your template with a global workflow run and would like to ensure that we don't bring any unnecessary HAFS settings into the global nest runs. Do you want me to continue and go through all the namelist parameters in the template?

Yes.

1. no more full_zs_filter
2. &surf_map_nml entries that do not have the namelist default are variables
3. Reorganize and comment gnv1_nested
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_parent.nml.IN
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_parent.nml.IN Outdated
Comment thread tests/parm/input_global_nest.nml.IN
Comment thread tests/parm/input_global_nest.nml.IN Outdated
Comment thread tests/parm/input_global_nest.nml.IN
Copy link
Copy Markdown

@guoqing-noaa guoqing-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 - When could this PR be merged?
It is holding up a global-workflow pull request, so I'd rather not delay too long.
The changes are low-risk (no subcomponent PRs) and confined to one regression test. You may be able to combine it with other PRs.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Jun 6, 2024

@jkbk2004 - When could this PR be merged? It is holding up a global-workflow pull request, so I'd rather not delay too long. The changes are low-risk (no subcomponent PRs) and confined to one regression test. You may be able to combine it with other PRs.

@SamuelTrahanNOAA Sorry for the backlog! We will check if we can combine either #2279 or #2186. Possibly to schedule either tomorrow or Monday.

@jkbk2004
Copy link
Copy Markdown
Collaborator

merged with #2186

@jkbk2004 jkbk2004 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a global_nest_v1 regression test that uses the Water in the West domain

4 participants