Skip to content

add a model_configure template for global nest#2252

Closed
guoqing-noaa wants to merge 2 commits into
ufs-community:developfrom
guoqing-noaa:nestconfig
Closed

add a model_configure template for global nest#2252
guoqing-noaa wants to merge 2 commits into
ufs-community:developfrom
guoqing-noaa:nestconfig

Conversation

@guoqing-noaa
Copy link
Copy Markdown

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

add a model_configure template for global nest

Commit Message:

add a model_configure template for global nest
tests/parm/model_configure_nest.IN

Priority:

  • High: Need this template file to run the global-nest workflow

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.
  • Just add a model_configure template under tests/parm, no need to run RT suite and commit test_changes.list.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@jkbk2004 This PR is requesting high priority.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Which regression test is using (testing) this template?

@guoqing-noaa
Copy link
Copy Markdown
Author

Which regression test is using (testing) this template?

This is a new template for the global nest applications. No existing regression tests for it.
@SamuelTrahanNOAA is trying to add a global nest regression test to this repo. Could you convert this PR to a draft PR at this moment? Thanks!

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

SamuelTrahanNOAA commented May 7, 2024

There are regression tests in the repository already. I'm replacing one of them.

These are the tests:

  1. gnv1_c96_no_nest_debug - unnested uncoupled C96 GFS with global_nest_v1 physics suite. Code is compiled in debug mode. Run for GNU and Intel compilers. It uses the exact same C96 input as dozens of other ufs-weather-model regression tests.
  2. gnv1_nested - HAFS North Atlantic global nested test case with global_nest_v1 physics. This is the same input used for other HAFS global cases. Compiled optimized; intel only.

I'm replacing the second one (gnv1_nested). It'll use the Water in the West domain instead of the HAFS North Atlantic domain. Also, it'll be based on the GFS-like regression tests (using control_run.IN) so it'll be more compatible with the global-workflow.

Comment on lines +41 to +53
<output_grid_02>
output_grid: @[NEST_OUTPUT_GRID]
imo: @[NEST_IMO]
jmo: @[NEST_JMO]
cen_lon: @[TARGET_LON]
cen_lat: @[TARGET_LAT]
lon1: @[NEST_LON1]
lat1: @[NEST_LAT1]
lon2: @[NEST_LON2]
lat2: @[NEST_LAT2]
dlon: @[NEST_DLON]
dlat: @[NEST_DLAT]
</output_grid_02>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the variables currently used in the regression tests:

Suggested change
<output_grid_02>
output_grid: @[NEST_OUTPUT_GRID]
imo: @[NEST_IMO]
jmo: @[NEST_JMO]
cen_lon: @[TARGET_LON]
cen_lat: @[TARGET_LAT]
lon1: @[NEST_LON1]
lat1: @[NEST_LAT1]
lon2: @[NEST_LON2]
lat2: @[NEST_LAT2]
dlon: @[NEST_DLON]
dlat: @[NEST_DLAT]
</output_grid_02>
<output_grid_02>
output_grid: @[OUTPUT_GRID_2]
imo: @[IMO_2]
jmo: @[JMO_2]
cen_lon: @[CEN_LON_2]
cen_lat: @[CEN_LAT_2]
lon1: @[LON1_2]
lat1: @[LAT1_2]
lon2: @[LON2_2]
lat2: @[LAT2_2]
dlon: @[DLON_2]
dlat: @[DLAT_2]
</output_grid_02>

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

SamuelTrahanNOAA commented May 7, 2024

I'm unclear on what is gained by merging this PR. The reason it is high priority is that a global-workflow PR needs a model_configure for the global_nest_v1 suite. However, the global-workflow PR generates an incorrect input.nml. Its namelist settings don't match the ccpp suite. The new file isn't used by any regression test yet.

Also, the NEST_ variables won't work long-term. What if there is more than one nest?

I'll have another PR soon with a regression test that has a correct namelist.

@guoqing-noaa
Copy link
Copy Markdown
Author

I'm unclear on what is gained by merging this PR. The reason it is high priority is that a global-workflow PR needs a model_configure for the global_nest_v1 suite. However, the global-workflow PR generates an incorrect input.nml. Its namelist settings don't match the ccpp suite. The new file isn't used by any regression test yet.

Also, the NEST_ variables won't work long-term. What if there is more than one nest?

I'll have another PR soon with a regression test that has a correct namelist.

@SamuelTrahanNOAA If you will create another PR, I will close this PR. Thanks!

@SamuelTrahanNOAA
Copy link
Copy Markdown
Collaborator

My replacement PR is #2284. Unfortunately, the model isn't stable for the C96 case, and I have no fix for that yet. Please see that PR for details.

@guoqing-noaa
Copy link
Copy Markdown
Author

Close this PR. The issue is addressed at PR #2284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants