Skip to content

[production/RRFS.v1] Update module_write_netcdf to avoid hangs in RRFS runs#2212

Merged
MatthewPyle-NOAA merged 6 commits into
ufs-community:production/RRFS.v1from
DusanJovic-NOAA:rrfs_v1_write_netcdf_hangs
Apr 2, 2024
Merged

[production/RRFS.v1] Update module_write_netcdf to avoid hangs in RRFS runs#2212
MatthewPyle-NOAA merged 6 commits into
ufs-community:production/RRFS.v1from
DusanJovic-NOAA:rrfs_v1_write_netcdf_hangs

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Mar 28, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM - 
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

  • AQM:
  • CDEPS:
  • CICE:
  • CMEPS:
  • CMakeModules:
  • FV3:
    • ccpp-physics:
    • atmos_cubed_sphere:
  • GOCART:
  • HYCOM:
  • MOM6:
  • NOAHMP:
  • WW3:
  • stochastic_physics:
  • None

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • New input data.
  • Updated input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@hu5970
Copy link
Copy Markdown

hu5970 commented Apr 1, 2024

The tests with RRFS_A on development machine are successful. Please merge this PR.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 1, 2024

@MatthewPyle-NOAA #2193 is on-going. So it's good timing to work on this pr as well. I need to test if we can use Hera rocky8 in this pr.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 1, 2024

@DusanJovic-NOAA can you convert draft pr to pr?

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as ready for review April 1, 2024 21:06
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 1, 2024

@MatthewPyle-NOAA We can start merging process if we don't need to test on more than hera/hercules/wcoss2 machines. #2193 ran all ok. So, I think we are good to merge the pr.

Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...approving.

@MatthewPyle-NOAA
Copy link
Copy Markdown
Collaborator

@jkbk2004 Can help with merging later today - let me know what you need me to do.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 2, 2024

@DusanJovic-NOAA can you update fv3 hash: NOAA-EMC/ufsatm@c01786d ?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA can you update fv3 hash: NOAA-EMC/fv3atm@c01786d ?

Done.

Copy link
Copy Markdown
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Apr 2, 2024

@MatthewPyle-NOAA All looks good. This pr can be merged.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit b4a006e into ufs-community:production/RRFS.v1 Apr 2, 2024
@DusanJovic-NOAA DusanJovic-NOAA deleted the rrfs_v1_write_netcdf_hangs branch April 2, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants