[production/RRFS.v1] Update module_write_netcdf to avoid hangs in RRFS runs#810
Merged
MatthewPyle-NOAA merged 1 commit intoApr 2, 2024
Conversation
DusanJovic-NOAA
changed the title
DusanJovic-NOAA
changed the title
14 tasks
Collaborator
|
@MatthewPyle-NOAA Tests are done at ufs-community/ufs-weather-model#2212. This pr can be merged with the approval. |
MatthewPyle-NOAA
approved these changes
Apr 2, 2024
grantfirl
pushed a commit
to grantfirl/ufsatm
that referenced
this pull request
Oct 29, 2024
Changes made to address netcdf write hangs within RRFS system
jkbk2004
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Update io/module_write_netcdf.F90 (#810) * [production/RRFS.v1] Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!) (#812) * Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!) * Move ebu_smoke outside of extended_sd_diag IF block in diagnostics --------- Co-authored-by: jordanschnell <jordan.schnell@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates io/module_write_netcdf.F90 to resolve RRFS hangs. It brings in the changes from develop branch.
See fv3atm develop branch PR #803
See ufs-weather-model issue ufs-community/ufs-weather-model#2174
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs