Skip to content

fv3 changes for s2s one step cold start #202

Merged
junwang-noaa merged 13 commits into
ufs-community:developfrom
junwang-noaa:weather-cmepsIC
Sep 16, 2020
Merged

fv3 changes for s2s one step cold start #202
junwang-noaa merged 13 commits into
ufs-community:developfrom
junwang-noaa:weather-cmepsIC

Conversation

@junwang-noaa
Copy link
Copy Markdown
Collaborator

Description

This PR contains fv3 code changes to set up on step cold start.

  1. fv3 is now set up the bottom layer coupled fields at the end of initialization step.
  2. previous diagnostic subroutine Dump_cplFields is renamed to diagnose_cplFields.
  3. Debug option -link_mpi=dbg is added to debug tests.

Issue(s) addressed

Testing

RT will be conducted on wcoss, hera and orion.

Dependencies

@junwang-noaa junwang-noaa changed the title point to fv3 branch fv3_cmepsIC fv3 changes for s2s one step cold start Sep 15, 2020
Comment thread cmake/Intel.cmake Outdated
@climbfuji
Copy link
Copy Markdown
Collaborator

@junwang-noaa should I run tests on cheyenne. intel with both gnumake and cmake?

@junwang-noaa
Copy link
Copy Markdown
Collaborator Author

junwang-noaa commented Sep 16, 2020 via email

@climbfuji
Copy link
Copy Markdown
Collaborator

I did not run gnumake in ufs-weather model, only cmake. I did not add link_mpi option to compile configuration files (conf/*) on platforms other than wcoss, hera and orion, you may want to check if it is working on cheyenne.

In fact, you added it to conf/configure.fv3.cheyenne.intel, that's why I was asking. I'll test it!

@junwang-noaa
Copy link
Copy Markdown
Collaborator Author

junwang-noaa commented Sep 16, 2020 via email

@climbfuji
Copy link
Copy Markdown
Collaborator

Great, I did not test it.

I think we need to tiny changes to conf/configure.fv3.cheyenne.intel and conf/configure.fv3.cheyenne.gnu, not directly related to this PR. There are missing dependencies on POST_LIB with gnumake that my usual regression testing using ecflow/cmake didn't catch.

The rest is looking good, although the regression tests are still running.

@climbfuji
Copy link
Copy Markdown
Collaborator

Great, I did not test it.

I think we need to tiny changes to conf/configure.fv3.cheyenne.intel and conf/configure.fv3.cheyenne.gnu, not directly related to this PR. There are missing dependencies on POST_LIB with gnumake that my usual regression testing using ecflow/cmake didn't catch.

The rest is looking good, although the regression tests are still running.

Update: all debug compile jobs fail on cheyenne, because even though cheyenne.intel is using the Intel compiler, it is not using Intel MPI, but SGI MPT. We need to add the same logic to the cmake and gnumake config that you added for wcoss. And probably need the same for gaea, too. I can make those changes and send you a PR to update your branch. This will not require rerunning the regression tests, since these are only machine-dependent configuration changes for machines other than tier-1 platforms.

@junwang-noaa
Copy link
Copy Markdown
Collaborator Author

junwang-noaa commented Sep 16, 2020 via email

…rary dependencies for cheyenne.{intel,gnu} gnumake config
climbfuji and others added 2 commits September 16, 2020 10:29
…200916

Cheyenne and Gaea updates for PR "fv3 changes for s2s one step cold start"
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just need to update the fv3atm submodule pointer and revert the .gitmodules changes.

@junwang-noaa junwang-noaa merged commit a31bb7c into ufs-community:develop Sep 16, 2020
@junwang-noaa junwang-noaa deleted the weather-cmepsIC branch October 30, 2020 14:40
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
…, updates to other GSL physics (ufs-community#202)

This PR updates the GSL physics and does a few other things:

*add --debug to ccpp_prebuild.py call when model is compiled in DEBUG mode, and pretty print the output in the build log (fixes ufs-community#187 and ufs-community#135)
*add unified gravity wave drag (called unified ugwp) that combines the UGWP v1 with the GSL drag suite
*add suite definition file for GFS v16beta for coupled model
*move static array zs (depth of soil layer), dimensioned as 1:lsoil_lsm from Sfcprop to Model (since this is a model configuration and only needs to be stored once, not for each block)

Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com>
Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov>
Co-authored-by: hannah barnes <hannah.barnes@noaa.gov>
Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov>
Co-authored-by: Joseph Olson <Joseph.B.Olson@noaa.gov>
Co-authored-by: Michael Toy <michael.toy@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants