Update links and version numbers from 1.0.0 to 1.1.0#187
Merged
JulieSchramm merged 5 commits intoSep 1, 2020
Merged
Conversation
Both html and latex builds succeed.
ligiabernardet
requested changes
Aug 19, 2020
| 4. Merging code from PRs with submodules requires coordination with the person making the PRs. From the "innermost" nested PR up to the top-level PR, the PRs need to be merged as-is. After each merge, the person creating the PRs has to update his/her local code to check out the merged version, revert the change to .gitmodules, and push this to GitHub to update the PR. And so on and so forth. | ||
|
|
||
| 5. Checking out the code ufs_release_1.0 should always be as follows: | ||
| 5. Checking out the code for this v1.1.0 release should be as follows: |
Collaborator
There was a problem hiding this comment.
While the instructions here are technically correct, developers should not be working from the tag. They need to check out and contribute to the develop branch. I will discuss this with @JulieSchramm for a possible follow up PR. For this PR, this is okay.
| addressed is variable `nstf_name`. For more information about this variable and for information about | ||
| namelist options for higher resolution configurations, please consult the | ||
| `CCPP v4 Scientific Documentation <https://dtcenter.org/GMTB/v4.0/sci_doc/>`_. | ||
| `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. |
Collaborator
There was a problem hiding this comment.
Suggested change
| `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. | |
| `CCPP v4.1.0 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
|
|
||
| An in depth description of the namelist settings, SDFs, and parameterizations used | ||
| in all supported suites can be found in the `CCPP v4 Scientific Documentation <https://dtcenter.org/GMTB/v4.0/sci_doc/>`_. | ||
| in all supported suites can be found in the `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. |
Collaborator
There was a problem hiding this comment.
Suggested change
| in all supported suites can be found in the `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. | |
| in all supported suites can be found in the `CCPP v4.1.0 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
| The following link describes the stochastic physics namelist records: | ||
|
|
||
| https://stochastic-physics.readthedocs.io/en/ufs-v1.0.0/namelist_options.html | ||
| https://stochastic-physics.readthedocs.io/en/release-ufs-v1.1.0/namelist_options.html |
Collaborator
There was a problem hiding this comment.
Two lines above there is a link to https://dtcenter.org/GMTB/v4.0/sci_doc/CCPPsuite_nml_desp.html that needs to be updated to v4.1.1
ligiabernardet
requested changes
Aug 19, 2020
|
|
||
| An in depth description of the namelist settings, SDFs, and parameterizations used | ||
| in all supported suites can be found in the `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. | ||
| in all supported suites can be found in the `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
Collaborator
There was a problem hiding this comment.
Suggested change
| in all supported suites can be found in the `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. | |
| in all supported suites can be found in the `CCPP v4.1.0 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
| addressed is variable `nstf_name`. For more information about this variable and for information about | ||
| namelist options for higher resolution configurations, please consult the | ||
| `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1/sci_doc/>`_. | ||
| `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
Collaborator
There was a problem hiding this comment.
Suggested change
| `CCPP v4.1 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. | |
| `CCPP v4.1.0 Scientific Documentation <https://dtcenter.org/GMTB/v4.1.0/sci_doc/>`_. |
Collaborator
|
@JulieSchramm I would like to request one more change wrt links. In Chapter 4 (Inputs and Outputs), please replace this link https://www.gfdl.noaa.gov/wp-content/uploads/2017/09/fv3_namelist_Feb2017.pdf with this one https://noaa-emc.github.io/FV3_Dycore_ufs-v1.1.0/html/index.html. The HTML in github.io has additional information beyond what is in the PDF (Valbona worked with GFDL to augment it). The v1.1.0 is not ready yet (it will be a broken link). But soon it shoudl be stood up and look similar to the existing https://noaa-emc.github.io/FV3_Dycore_ufs-v1.0.0/html/index.html. |
added 3 commits
August 20, 2020 09:41
Replace link to GFDL dycore. Both html and latex builds succeed.
- Contributing development content is in the UFS WM wiki page. - Add links wiki page and remove mention of Chapter 6. - Remove RT from Acronyms - Minor corrections to Introduction Both html and latex builds succeed.
ligiabernardet
approved these changes
Sep 1, 2020
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model.p7b
that referenced
this pull request
Jul 20, 2021
…, updates to other GSL physics (ufs-community#202) This PR updates the GSL physics and does a few other things: *add --debug to ccpp_prebuild.py call when model is compiled in DEBUG mode, and pretty print the output in the build log (fixes ufs-community#187 and ufs-community#135) *add unified gravity wave drag (called unified ugwp) that combines the UGWP v1 with the GSL drag suite *add suite definition file for GFS v16beta for coupled model *move static array zs (depth of soil layer), dimensioned as 1:lsoil_lsm from Sfcprop to Model (since this is a model configuration and only needs to be stored once, not for each block) Co-authored-by: DomHeinzeller <58610420+DomHeinzeller@users.noreply.github.com> Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov> Co-authored-by: hannah barnes <hannah.barnes@noaa.gov> Co-authored-by: tanyasmirnova <tanya.smirnova@noaa.gov> Co-authored-by: Joseph Olson <Joseph.B.Olson@noaa.gov> Co-authored-by: Michael Toy <michael.toy@noaa.gov>
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update links and version numbers for v1.1 release
Issue(s) addressed
No issues.
Testing
Only the documentation was modified, both html and latex builds succeed.
Dependencies
None.