[GOCART] update to gocart hash f7b34e - important updates for FENGSHA#1922
Conversation
|
Ran the |
|
@rmontuoro @junwang-noaa If #1920 is going to be delayed I suggest that we push this through as its critical for the EP5 experiments |
|
just re-synced and so this should be ready @junwang-noaa @DeniseWorthen @rmontuoro |
|
@bbakernoaa do you have the RegressionTests_hera.log available for the run against this PR? It looks like 1920 will be held a bit longer and we think it would be best to move forward with this PR. Edit: hera logs attached now. |
|
@BrianCurtis-NOAA FYI: we started working on this pr. |
|
Jenkins-ci ORTs failed |
Thanks. I did not have them attached. |
|
Jenkins-ci ORTs failed |
Working on this. Instances are not starting up it seems. |
|
@bbakernoaa I wanted to warn you about using the same name of the auth branch in your merge branch from your personal fork, we typically recommend a unique name to your branch. Maybe It's not going to break anything but has higher potential for issues. No need to change anything, just an FYI. |
|
Testing is complete. @BrianCurtis-NOAA @SadeghTabas-NOAA @jkbk2004 . Final review requests have been sent to you. |
|
@BrianCurtis-NOAA Understood. It was a mistake and I just never went back to fix it. I'll make sure I don't repeat this mistake again. |
PR Author Checklist:
Description
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: