Lightning threat indexes

[SamuelTrahanNOAA]

Description

Calculates the lightning threat index product from HRRR, inside CCPP and sends it to UPP for output.

The algorithm was originally ported from HRRR to the GFDL_atmos_cubed_sphere NGGPS diagnostics, using the w variable in both implementations. I've moved it to CCPP's maximum hourly diagnostics, but it still needs w in the formulation, so I've added the dynamical core's w variable as wgrs to match the u & v winds which are ugrs and vgrs.

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.

Anticipated changes to regression tests:

• Many regression test results may change due to updating to the latest UPP and adding fields to regional output.

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

I suggest combining this with my PR #1361 which adds other UPP diagnostic output.

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

• Depends on Lightning threat indexes NOAA-EMC/ufsatm#628

• Depends on Lightning threat indexes ccpp-physics#42

• Depends on Lightning Threat Indexes: pass w to model NOAA-GFDL/GFDL_atmos_cubed_sphere#243

• Depends on CALSLR_ROEBBER: Instead of calling BOUND incorrectly, use min and max NOAA-EMC/UPP#673

• Closes: Lightning Threat Indexes #1632

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[jkbk2004]

OK! all tests are done. We can start merging process.

[jkbk2004]

@SamuelTrahanNOAA I will go to ask to merge upstream dependencies.

[jkbk2004]

BTW, Gaea C4 jobs are not moving at all. An email sent out to Gaea admin.

[jkbk2004]

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: BL
[BL] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/1265303346/20230323031507/ufs-weather-model
Please make changes and add the following label back: gaea-intel-BL

[jkbk2004]

@SamuelTrahanNOAA all set! can you update fv3 pointer and revert changes in gitmodules?

[SamuelTrahanNOAA]

The fv3atm should be right now.

[SamuelTrahanNOAA]

I had forgotten to push that change. Now that the acorn modulefiles are updated, I suggest you rerun the regression tests there, to make sure it runs in your account and reproduces the baseline.

[BrianCurtis-NOAA]

I'm fairly certain I ran with the updated modulefiles. I tried a pull and it did not pick up any modulefiles changes and the change shows in my clone. No need to re-run on Acorn.

[jkbk2004]

@BrianCurtis-NOAA I agree. PR is ready to merge.

[jkbk2004]

Please, go ahead to approve the PR.

[grantfirl]

@SamuelTrahanNOAA Do you have any guidance to help us understand which RTs are expected to fail with this? We're moving these changes to the NCAR fork (NCAR#92) and re-running RTs there and we'd like to understand which tests should fail with the UPP and regional output changes.

[SamuelTrahanNOAA]

@SamuelTrahanNOAA Do you have any guidance to help us understand which RTs are expected to fail with this? We're moving these changes to the NCAR fork (NCAR#92) and re-running RTs there and we'd like to understand which tests should fail with the UPP and regional output changes.

When one updates UPP, any GRIB files may change output. The regional* tests will also change due to the new diag_table. Put together, that's nearly all of the tests.