Update WW3 #1474
Closed
DeniseWorthen wants to merge 20 commits into
Closed
Conversation
4 tasks
*all wave baselines B4B hera.intel, hera.gnu
16 tasks
Collaborator
Author
|
@MatthewMasarik-NOAA This PR is being combined with a couple of AQM PRs and is going to start testing today for commit. The changes in WW3 are whitespace + a bug fix. |
Collaborator
@DeniseWorthen, great! Thanks for the update. We'll start looking at the bug fix on our end. |
Collaborator
Author
|
@MatthewMasarik-NOAA Just FYI, we have no application which exercises the cice6-wave coupling. The issue was found during testing for an unrelated CMEPS PR. |
Collaborator
|
@DeniseWorthen okay, thanks for the heads up. I'll make note of that. |
Collaborator
Author
|
Closing; PR is combined with #1476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Updates WW3 for auto-formatting, cleanup of whitespace and some #ifdef removal.
Issue(s) addressed
fixes #1473
Testing
All tests containing waves were run on hera.intel and hera.gnu. All baselines were b4b at 9ae1b4f. Tests were re-run after wave_spectrum export fix and were again b4b at 170614b
Dependencies
waiting on NOAA-EMC/WW3#840