apply autoformatting; update to latest develop for dev/ufs-weather-model branch; fix wave_elevation export for coupling with CICE6#840
Merged
MatthewMasarik-NOAA merged 16 commits intoNov 3, 2022
Conversation
This reverts commit cef6d7d.
…ailing whitespace. (NOAA-EMC#808) co-author @mvertens
* checked against autoformatted copy of MattM/syncdevufs. no unexpected differences
* compared against autoformatted dev/uwm branch. no unexpected changes
DeniseWorthen
changed the title
DeniseWorthen
changed the title
16 tasks
* calc ebd as scalar and use it directly as the wav_elevation_spectrum * changes are b4b compared to the initial implementation of calcef
DeniseWorthen
changed the title
Contributor
MatthewMasarik-NOAA
left a comment
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
Visual inspection looks good to me.
Contributor
Author
|
Update of WW3 in UWM has been rolled into UWM ufs-community/ufs-weather-model#1456 |
16 tasks
Contributor
|
We're ready for reviews/merge on the UFSWM side. |
Contributor
Great. We'll merge now on this side. |
MatthewMasarik-NOAA
approved these changes
Nov 3, 2022
Contributor
MatthewMasarik-NOAA
left a comment
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
All looks well.
Contributor
|
Thanks @DeniseWorthen, for this huge step in cleaning up the WW3 code base! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Apply autoformatting and white space removal to dev/ufs-weather-model branch. Update to latest develop. Fix export of wave_elevation spectrum to be updated at coupling frequency when coupled with CICE6.
Description
Apply autoformatting and white space removal to dev/ufs-weather-model branch. Update to latest develop. No change to baselines for UWM regression tests (ufs-community/ufs-weather-model#1474)
Issue(s) addressed
fixes issues #796 and #797 for ufs-weather-model branch
fixes issue #843
Commit Message
Apply autoformatting and white space removal to dev/ufs-weather-model branch. Update to latest develop. Fix export of wave_elevation spectrum to be updated at coupling frequency when coupled with CICE6.
co-author: @mvertens
Check list
Testing