Bug fix for #1309: false reports of test failures#1312
Closed
SamuelTrahanNOAA wants to merge 2 commits into
Closed
Bug fix for #1309: false reports of test failures#1312SamuelTrahanNOAA wants to merge 2 commits into
SamuelTrahanNOAA wants to merge 2 commits into
Conversation
Collaborator
Author
|
This PR should be combined with one that has to generate baselines, to fully test the regression test system. |
Collaborator
|
@SamuelTrahanNOAA Thanks for the fix, it looks good to me. |
Collaborator
Author
|
This was merged with #1292 so I'm closing it. |
SamuelTrahanNOAA
added a commit
to NOAA-GSL/ufs-weather-model
that referenced
this pull request
Aug 8, 2022
SamuelTrahanNOAA
added a commit
to hannahcbarnes/ufs-weather-model
that referenced
this pull request
Aug 8, 2022
…orts of test failures ufs-community#1312"
SamuelTrahanNOAA
added a commit
to NOAA-GSL/ufs-weather-model
that referenced
this pull request
Aug 18, 2022
* - Updates to GF and sgscloud_radpre for HFIP * -Bug fixes * bugfix from ufs-community: "Bug fix for ufs-community#1309: false reports of test failures ufs-community#1312" * pefc was declared twice, which annoyed gnu * bugfix from develop: do not complete workflow when all compile jobs fail * update baseline date * update ccpp/physics hash * hera.gnu tests passed * hera.intel tests passed * jet intel tests passed Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Description
Fixes a known issue in the regression test system which can cause successful tests to be reported as failing.
Issue(s) addressed
fixes #1309
Testing
Ran tests on Hera, causing jobs to fail in various ways and then succeed. The fix seems to work. I want to test on Jet once it's back since that system has had the most trouble.
Dependencies
None.