Skip to content

- Updates to GF and sgscloud_radpre for HFIP 2022#147

Merged
SamuelTrahanNOAA merged 13 commits into
NOAA-GSL:HFIP2022from
hannahcbarnes:HFIP2022_hannah
Aug 18, 2022
Merged

- Updates to GF and sgscloud_radpre for HFIP 2022#147
SamuelTrahanNOAA merged 13 commits into
NOAA-GSL:HFIP2022from
hannahcbarnes:HFIP2022_hannah

Conversation

@hannahcbarnes
Copy link
Copy Markdown

@hannahcbarnes hannahcbarnes commented Aug 3, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • GF Changes
- Merra2 AOD read into GF, replaces assumed globally uniform AOD. This change is more realistic. 
- Removes edtmax and edtmin
- Removes double counting in sgscloud_radpre when GF is used
- Output updraft mass flux and precipitation includes the all elements of the tri-modal precipitation desciption (small, mid, and deep can co-exist in one grid point)
- Mass factor included in pwav, pwev, and pwavh. 
- psum, psumh is removed since that variable is the same as pwav, pwavh
- Assumed precipitation efficiency is increased
- Temperature and specific humidity input into is now updated by the previous parameterizations
- -z_detr increased to 1000

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@SamuelTrahanNOAA SamuelTrahanNOAA changed the base branch from HFIP2022_joe to HFIP2022 August 16, 2022 21:16
@SamuelTrahanNOAA SamuelTrahanNOAA merged commit b42ca73 into NOAA-GSL:HFIP2022 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants