Skip to content

Single time-step output#1205

Closed
pjpegion wants to merge 7 commits into
ufs-community:developfrom
pjpegion:single_dt_output
Closed

Single time-step output#1205
pjpegion wants to merge 7 commits into
ufs-community:developfrom
pjpegion:single_dt_output

Conversation

@pjpegion
Copy link
Copy Markdown
Collaborator

@pjpegion pjpegion commented May 6, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The current logic in CCPP_driver does not allow for buckets to be emptied every time-step.
This one-line modification fixes that.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@junwang-noaa junwang-noaa added the No Baseline Change No Baseline Change label Jun 2, 2022
@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Jun 2, 2022

@pjpegion Hi Phil, I think we may combine this PR to Dusan's #1239. So that we can merge together. Could you make a PR to Dusan's?

@pjpegion
Copy link
Copy Markdown
Collaborator Author

pjpegion commented Jun 2, 2022

Will do

@junwang-noaa
Copy link
Copy Markdown
Collaborator

The PR was merged in PR#1239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error in single time-step physics output

3 participants