modify fhzero logic in emptying buckets#531
Merged
Merged
Conversation
climbfuji
reviewed
May 13, 2022
Collaborator
Author
|
I assume going from mod 1 to mod 0 would change the baseline, since the buckets would be emptied 1 timestep earlier
…Sent from my iPhone
On May 13, 2022, at 2:30 PM, Dom Heinzeller ***@***.***> wrote:
@climbfuji commented on this pull request.
In ccpp/driver/CCPP_driver.F90:
> @@ -149,7 +149,7 @@ subroutine CCPP_step (step, nblks, ierr)
endif
!--- determine if physics diagnostics buckets need to be cleared
- if (mod(GFS_control%kdt,GFS_control%nszero) == 1) then
+ if ((mod(GFS_control%kdt-1,GFS_control%nszero)+1) == 1) then
How is that different from
if (mod(GFS_control%kdt,GFS_control%nszero) == 0) then
?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.
|
Collaborator
Yes, of course, you are right. |
climbfuji
approved these changes
May 13, 2022
16 tasks
DusanJovic-NOAA
approved these changes
Jun 6, 2022
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current logic in CCPP_driver does not allow for buckets to be emptied every time-step.
This one-line modification fixes that.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
running 24-hour forecasts, saving every time-step. Time-averaged fields no longer accumulate with time.
What compilers / HPCs was it tested with?
Hera/intel
Are the changes covered by regression tests?
No, and I am not sure if we want an RT with this.
Have the ufs-weather-model regression test been run? On what platform?
Limited set have been run on hera.
-NO
Dependencies
None