Skip to content

[develop] Add correct logic for 3-digit forecast hours in UPP #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelLueken merged 1 commit into from
Feb 10, 2023
Merged

[develop] Add correct logic for 3-digit forecast hours in UPP #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions scripts/exregional_run_post.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,14 +240,8 @@ if [ ${len_fhr} -eq 2 ]; then
elif [ ${len_fhr} -eq 3 ]; then
if [ "${fhr:0:1}" = "0" ]; then
post_fhr="${fhr:1}"
# What should happen in the "else" case? Would just setting post_fhr to
# fhr work? Need to test.
else
print_err_msg_exit "\
The \${fhr} variable contains a 3-digit integer whose first digit is not
0. In this case, it is not clear how to set the variable post_fhr used
in constructing the grib2 file names generated by UPP:
fhr = \"$fhr\""
post_fhr="${fhr}"
Copy link
Copy Markdown
Collaborator

@christinaholtNOAA christinaholtNOAA Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment here on WHY this is necessary might help the next person from going down the rabbit hole you described in personal communications.

fi
else
print_err_msg_exit "\
Expand Down