[develop] Add correct logic for 3-digit forecast hours in UPP#607
Conversation
mkavulich
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
MichaelLueken,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
gspetro-NOAA,
jkbk2004,
mark-a-potts,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
| 0. In this case, it is not clear how to set the variable post_fhr used | ||
| in constructing the grib2 file names generated by UPP: | ||
| fhr = \"$fhr\"" | ||
| post_fhr="${fhr}" |
There was a problem hiding this comment.
A comment here on WHY this is necessary might help the next person from going down the rabbit hole you described in personal communications.
MichaelLueken
left a comment
MichaelLueken
left a comment
There was a problem hiding this comment.
@mkavulich This change looks good to me!
MichaelLueken
added
run_we2e_coverage_tests
venitahagerty
removed
the
ci-hera-intel-WE
|
Machine: hera |
|
The Jenkins tests successfully completed for non-Hera machines and the GHA Hera WE2E test successfully completed. Moving forward with merging. |
4 participants
DESCRIPTION OF CHANGES:
Adding correct logic for 3-digit forecast hours in UPP. The filenames coming out of UPP are unfortunately hard-coded in that all forecast hours below 100 will have a 2-digit forecast hour in the filename, and beyond that will switch to a 3-digit forecast hour. The current workflow does not attempt to resolve this difference, resulting in UPP tasks failing after (despite the executable completing successfully). This change adds the correct logic to allow UPP tasks to succeed beyond 99 hours.
Type of change
TESTS CONDUCTED:
Ran a 108-hour forecast (using the
config.yamlshown in #601) on Hera and Jet, confirmed that the fix works for 3-digit forecast hours. Ran the comprehensive test suite on Jet and no new failures were observed; all post tasks succeeded.DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE:
Fixes issue mentioned in #601
CHECKLIST