Skip to content

[release/public-v2.1.0] Updates to SRW configuration for MacOS #469

Closed
natalie-perlin wants to merge 13 commits into
ufs-community:release/public-v2.1.0from
natalie-perlin:develop_macos
Closed

[release/public-v2.1.0] Updates to SRW configuration for MacOS #469
natalie-perlin wants to merge 13 commits into
ufs-community:release/public-v2.1.0from
natalie-perlin:develop_macos

Conversation

@natalie-perlin
Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

NB: Updates similar to the PR-467 merged to develop branch

Updates to modulefiles and Lmod initialization for MacOS machines, architecture-independent scripts.
Build modulefile now uses srw_common module with list of standard software modules for the release.

The following files have been updated:
./modulefiles/build_macos_gnu.lua
./modulefiles/wflow_macos.lua
./etc/lmod-setup.sh
./etc/lmod-setup.csh

Type of change

  • Update of a supported feature (non-breaking change which adds functionality)
  • This change requires a documentation update

DEPENDENCIES:

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • enhancement
  • documentation
  • release
  • high priority

Jesse McFarland and others added 13 commits November 4, 2022 15:44
* Add a move step to binaries for NCO purposes.

* Pass COMROOT to setpdy.

* Correct path of post dependency on forecat.

* Remove DATA_SHARED directory.

* Remove symlinks and use unique id for run_fcst instead.

* Remove forecast directory after post is done.

* Use raw workflow_id

* Add templated data paths to wcoss2 that use compath.py.

* Remove cron relaunch from config.nco

* Undo for_ICS/LBCS stuff in NCO mode.

* Remove RESTART symlinking because DATAFCST is accessible to all other tasks.

* Undo cyc addition to COMIN.

* Update devclean.

* Follow symlinks when tarring log files in Jenkins.

* Add memory otpion for get_extrn_ics/lbcs.

* Optimize fundamental test coverage.

* Reduce work load on orion.

* Add minimum memory requirement to all serial tasks.

* Simplify set_predef_grid_params.

* Simplify generate_FV3LAM_wflow.

* Simplify link_fix.

* Simplify to get rid of export_vars from setup.

* Import only necessary variables from environment.

* Use `eval echo` or `eval` depending on situation.

* Add cyc back to COMIN.

* Fix calculate_cost.

* Fix gaea test list.

* Remove a test case from cheyenne that is taking extremely long.

* Reduce memory requirement for serial job to 1G.

* Create COMINaws ics/lbcs staging directory.

* Also symlink gfs ics/lbcs if on disk and in community mode.

* Remove failing tests on orion.

* Exclude gaea from --mem specification.

* Add a run_vx modulefile for orion.

* Add separate fundamental list for cheyenne GNU runs.

* Bug fix for wcoss2 GFS version

* Load prod_util on wcoss2.

* Rename AWSROOT to EXTROOT.

* Remove leftover COMINaws.
… new archive file name on HPSS (ufs-community#457)

* fix time offset with gfs

* add new archive file name and we2e test

* add ics_or_lbcs to test_retrieve.py

* Add check availability of nemsio and netcdf

* Copy file_templates dict before modifying it.

* remove native from xml for dev_transfer on wcoss2

* correct data locations on wcoss2

* remove met_verification from fundamental.cheyenne.gnu

* replace cyc to hh in data locations

* make lbcs condition general

Co-authored-by: Daniel Abdi <daniel.abdi@noaa.gov>
* Bug fix forecast directory deletion.

* Bug fix in build only mode.

* Remove unused sample.nc

* Make setup_WE2E work irrespective of conda activation.

* Fix the bug fix.
* [develop] Added return code to srw_build.sh script.

* Correct issue in sorc/CMakeLists.txt so that the ufs-model will build again.

* Restore PID functionality in tests/build.sh for GitHub Actions autoci builds.

* Add return code to tests/build.sh and read the code in srw_build.sh.
architecture-independent method
use conda environment and conda activate command
updates for MacOS
updates for MacOS
updated for MacOS
@MichaelLueken
Copy link
Copy Markdown
Collaborator

@natalie-perlin Unfortunately, you will need to create a separate branch off of the authoritative release/public-v2.1.0 release branch and then apply the changes to the four files that need to be changed. This PR will bring in all changes made to develop that haven't been made in the release branch. The release branch is frozen and only expected changes (like the MacOS configuration updates) will be approved. Please close this PR, create a new branch off of the release branch using:

  1. git remote add upstream https://github.com/ufs-community/ufs-srweather-app.git
  2. git remote update
  3. git checkout upstream/release/public-v2.1.0 -b release/public-v2.1.0_macos

You will now be in the release/public-v2.1.0_macos branch in your fork, where you can apply the modifications from PR #467. This will ensure that you only have the four desired changes in your PR.

Please let me know if you have any questions, comments, or concerns.

@MichaelLueken MichaelLueken changed the title Updates to SRW configuration for MacOS [release/public-v2.1.0] Updates to SRW configuration for MacOS Nov 11, 2022
@natalie-perlin
Copy link
Copy Markdown
Collaborator Author

@MichaelLueken - thank you for you comments! I will attempt to do it using the method you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants