[develop] Updates for building and running on MacOS (x86_64 and M1)#467
Merged
MichaelLueken merged 6 commits intoNov 11, 2022
Merged
Conversation
architecture-independent method
use conda environment and conda activate command
updates for MacOS
updates for MacOS
Collaborator
|
@natalie-perlin This PR will be merged to the develop branch, not the |
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@natalie-perlin Thank you very much for updating the MacOS the files necessary to build and run! I have two minor comments on your changes. Otherwise, these changes look good to me!
danielabdi-noaa
approved these changes
Nov 11, 2022
Collaborator
danielabdi-noaa
left a comment
There was a problem hiding this comment.
Good to see the move towards using conda and srw_common. Looks good to me so approving.
updated for MacOS
MichaelLueken
approved these changes
Nov 11, 2022
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@natalie-perlin Thanks! Now approving.
26 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Updates to modulefiles and Lmod initialization for MacOS machines, architecture-independent scripts.
Build modulefile now uses srw_common module with list of standard software modules for the release.
The following files have been updated:
./modulefiles/build_macos_gnu.lua
./modulefiles/wflow_macos.lua
./etc/lmod-setup.sh
./etc/lmod-setup.csh
Type of change
DEPENDENCIES:
LABELS (optional):
A Code Manager needs to add the following labels to this PR: