Skip to content

[develop] Updates for building and running on MacOS (x86_64 and M1)#467

Merged
MichaelLueken merged 6 commits into
ufs-community:developfrom
natalie-perlin:develop_macos
Nov 11, 2022
Merged

[develop] Updates for building and running on MacOS (x86_64 and M1)#467
MichaelLueken merged 6 commits into
ufs-community:developfrom
natalie-perlin:develop_macos

Conversation

@natalie-perlin
Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

Updates to modulefiles and Lmod initialization for MacOS machines, architecture-independent scripts.
Build modulefile now uses srw_common module with list of standard software modules for the release.

The following files have been updated:
./modulefiles/build_macos_gnu.lua
./modulefiles/wflow_macos.lua
./etc/lmod-setup.sh
./etc/lmod-setup.csh

Type of change

  • Update of a supported feature (non-breaking change which adds functionality)
  • This change requires a documentation update

DEPENDENCIES:

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • enhancement
  • documentation
  • release
  • high priority

architecture-independent method
use conda environment and conda activate command
updates for MacOS
updates for MacOS
@MichaelLueken
Copy link
Copy Markdown
Collaborator

@natalie-perlin This PR will be merged to the develop branch, not the release/public-v2.1.0 release branch. We can keep this PR open so that these changes are added to the develop branch as well, but a separate PR will need to be created to merge this work to the release branch.

@MichaelLueken MichaelLueken removed the release This PR/issue is related to a release branch label Nov 11, 2022
Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalie-perlin Thank you very much for updating the MacOS the files necessary to build and run! I have two minor comments on your changes. Otherwise, these changes look good to me!

Comment thread modulefiles/wflow_macos.lua Outdated
Comment thread modulefiles/wflow_macos.lua Outdated
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see the move towards using conda and srw_common. Looks good to me so approving.

updated for MacOS
Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalie-perlin Thanks! Now approving.

@MichaelLueken MichaelLueken merged commit 5356d1e into ufs-community:develop Nov 11, 2022
@JeffBeck-NOAA JeffBeck-NOAA changed the title Updates for building and running on MacOS (x86_64 and M1) [develop] Updates for building and running on MacOS (x86_64 and M1) Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants