-
Notifications
You must be signed in to change notification settings - Fork 130
[develop] Improve error messaging and logging for generate_FV3LAM_wflow.py #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mkavulich
merged 26 commits into
ufs-community:develop
from
mkavulich:feature/improve_error_messaging
Oct 21, 2022
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
64c2928
Initial logging cleanup in generate_FV3LAM_wflow.py
mkavulich 6a07761
More updates for better logging and error messages
mkavulich 4e06bf0
Set up logging in setup.py
mkavulich b49ce0b
Add check that config.yaml contains only variables found in config_de…
mkavulich c68d217
Add checks for required python version and checks to run_WE2E_tests.sh
mkavulich 24211c1
More updates, fixes, and cleanup
mkavulich 2cad66b
More error/logging cleanup in setup.py
mkavulich 6e22e7d
More error/logging cleanup in setup.py and other files
mkavulich f749d15
More error/logging cleanup in setup.py
mkavulich c3cc0d3
Better logging name strategy, more error/logging cleanup in setup.py …
mkavulich 0535f8d
Finish error/logging cleanup in setup.py, set_thompson_mp_fix_files.py
mkavulich f0507fb
Last set of initial changes! Now just need to test and review...
mkavulich fe53633
First big change from more extensive testing:
mkavulich a91df94
Add testing subprocess code back in per Daniel Abdi's advice; this is
mkavulich 2ba941a
Forgot to set up logger for check_for_preexist_dir_file.py; not sure …
mkavulich a90be2d
More fixes to Daniels tests
mkavulich 6389c76
Add missing import to fix failing test
mkavulich c76df4f
Address some comments from Daniel: implement logging.info as its own
mkavulich 3835b9b
Fail with error if model executable does not exist
mkavulich 6f56ed6
Revert "Fail with error if model executable does not exist"
mkavulich 5b7093e
Restore "verbose" functionality now that we have a function
mkavulich 2d4f5b0
Missed one VERBOSE pass
mkavulich d2c9cbf
The f-string "=" specifier is not supported for python 3.6 (our minim…
mkavulich 73a5c50
Address reviewer comments
mkavulich d581228
Comment to clarify use of manual "raise" in setup.py
mkavulich d525918
One more comment addressed
mkavulich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.