[develop] Improve error messaging and logging for generate_FV3LAM_wflow.py#414

Merged

mkavulich merged 26 commits into

ufs-community:developfrom

mkavulich:feature/improve_error_messaging

Oct 21, 2022

Commits on Oct 21, 2022

Initial logging cleanup in generate_FV3LAM_wflow.py
mkavulich
committed
More updates for better logging and error messages
mkavulich
committed
Set up logging in setup.py
mkavulich
committed
Add check that config.yaml contains only variables found in config_defaults.yaml
mkavulich
committed
Add checks for required python version and checks to run_WE2E_tests.sh
mkavulich
committed
More updates, fixes, and cleanup
mkavulich
committed
More error/logging cleanup in setup.py
mkavulich
committed
More error/logging cleanup in setup.py and other files
mkavulich
committed
More error/logging cleanup in setup.py
mkavulich
committed
Better logging name strategy, more error/logging cleanup in setup.py and other files
mkavulich
committed
Finish error/logging cleanup in setup.py, set_thompson_mp_fix_files.py
mkavulich
committed
Last set of initial changes! Now just need to test and review...
mkavulich
committed
First big change from more extensive testing:
mkavulich
committed
Add testing subprocess code back in per Daniel Abdi's advice; this is
mkavulich
committed
Forgot to set up logger for check_for_preexist_dir_file.py; not sure why this didn't fail in manual tests...
mkavulich
committed
More fixes to Daniels tests
mkavulich
committed
Add missing import to fix failing test
mkavulich
committed
Address some comments from Daniel: implement logging.info as its own
mkavulich
committed
Fail with error if model executable does not exist
mkavulich
committed
Revert "Fail with error if model executable does not exist"
mkavulich
committed
Restore "verbose" functionality now that we have a function
mkavulich
committed
Missed one VERBOSE pass
mkavulich
committed
The f-string "=" specifier is not supported for python 3.6 (our minimum requirement); reverting to older format
mkavulich
committed
Address reviewer comments
mkavulich
committed
Comment to clarify use of manual "raise" in setup.py
mkavulich
committed
One more comment addressed
mkavulich
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[develop] Improve error messaging and logging for generate_FV3LAM_wflow.py#414

[develop] Improve error messaging and logging for generate_FV3LAM_wflow.py#414
mkavulich merged 26 commits into
ufs-community:developfrom
mkavulich:feature/improve_error_messaging

Commits on Oct 21, 2022

Initial logging cleanup in generate_FV3LAM_wflow.py

More updates for better logging and error messages

Set up logging in setup.py

Add check that config.yaml contains only variables found in config_defaults.yaml

Add checks for required python version and checks to run_WE2E_tests.sh

More updates, fixes, and cleanup

More error/logging cleanup in setup.py

More error/logging cleanup in setup.py and other files

More error/logging cleanup in setup.py

Better logging name strategy, more error/logging cleanup in setup.py and other files

Finish error/logging cleanup in setup.py, set_thompson_mp_fix_files.py

Last set of initial changes! Now just need to test and review...

First big change from more extensive testing:

Add testing subprocess code back in per Daniel Abdi's advice; this is

Forgot to set up logger for check_for_preexist_dir_file.py; not sure why this didn't fail in manual tests...

More fixes to Daniels tests

Add missing import to fix failing test

Address some comments from Daniel: implement logging.info as its own

Fail with error if model executable does not exist

Revert "Fail with error if model executable does not exist"

Restore "verbose" functionality now that we have a function

Missed one VERBOSE pass

The f-string "=" specifier is not supported for python 3.6 (our minimum requirement); reverting to older format

Address reviewer comments

Comment to clarify use of manual "raise" in setup.py

One more comment addressed