Update NEMS,FV3,CICE#28
Merged
DeniseWorthen merged 27 commits intoFeb 27, 2020
Merged
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
nomerg2atm, new MOM6 dev/emc
This reverts commit 57236a6.
Update FV3, NEMS (#21)
Update2020 01 (#23)
binli2337
approved these changes
Feb 27, 2020
Collaborator
binli2337
left a comment
There was a problem hiding this comment.
The changes look good to me.
Collaborator
|
Denise,
May I ask if the capability of writing out atm field on the native tile
grid is tested? I assume you are running fv3 and mediator with same tasks?
Does this add requirement of mediator to use multiple of 6 for number of
the pets if mediator and atm are not running on the same tasks. Thanks.
…On Thu, Feb 27, 2020 at 12:59 PM BinLi-NOAA ***@***.***> wrote:
***@***.**** approved this pull request.
The changes look good to me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AI7D6TLX2SAKQUHU4BA67WTRE75Q5A5CNFSM4K47ODVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXHNROQ#pullrequestreview-365877434>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TOZ3MNS6ITTI4RNTTDRE75Q5ANCNFSM4K47ODVA>
.
|
Collaborator
Author
|
Jun--we do run with the mediator and atm on the same tasks (multiple of 6). I suspect you are right that this requires that we run on multiples of 6 for the mediator regardless of whether it is sharing w/ atm but only if the diagnostic field dumping was enabled. For s2s, I did verify that the fields "to/from atm" and "from/to med" are the same when field dumping is enabled. The only issue is lining up the time-slices. |
Collaborator
|
Thanks, that is great. I think the time slices are depending on when you
put the code of outputting those fields. FV3 has time checker for import
fields, so at least the field passing is not a problem.
…On Thu, Feb 27, 2020 at 1:42 PM Denise Worthen ***@***.***> wrote:
Jun--we do run with the mediator and atm on the same tasks (multiple of
6). I suspect you are right that this requires that we run on multiples of
6 for the mediator regardless of whether it is sharing w/ atm but only if
the diagnostic field dumping was enabled.
For s2s, I did verify that the fields "to/from atm" and "from/to med" are
the same when field dumping is enabled. The only issue is lining up the
time-slices.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AI7D6TMS2M3XQR3YWIOLGHDRFACTBA5CNFSM4K47ODVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENFPGLA#issuecomment-592114476>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TLQ4SW5JOMJQUPRANLRFACTBANCNFSM4K47ODVA>
.
|
JessicaMeixner-NOAA
approved these changes
Feb 27, 2020
Change baseline area from "update" to "master"
DeniseWorthen
referenced
this pull request
in DeniseWorthen/ufs-s2s-model
Feb 27, 2020
Update NEMS,FV3,CICE (#28)
ShanSunNOAA
pushed a commit
to ShanSunNOAA/ufs-s2s-model
that referenced
this pull request
Oct 28, 2020
Option to roll back Thompson MP to WRFv3.8.1 (RAPv5/HRRRv4), add stochastic perturbations code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for issue #27:
*Mediator-calculated fluxes in icy water are not used when running FV3 coupled
*FV3 is updated to import fields from CICE using CICE field names; the custom merge in the mediator phase prep_atm is no longer required and is removed
*Field names for SW fields exported by CICE have been changed and corresponding changes have been made in the mediator
*Use of Atm-Ocn fields on the Atm grid are commented out in mediator phase prep_atm since they are not used
*When diagnostic field dumping is enabled, both FV3 and NEMS write Atm fields on the native tile grid
*The NEMS EARTH_GRID_COMP is capable of building a second mediator (CMEPS).