change default resolution#204
Merged
DeniseWorthen merged 122 commits intoOct 21, 2020
Merged
Conversation
Feature/add comparisons (#4)
merge develop/ufs-s2s-model
MOM_input template for initial condition files
merge fv3atm/develop
This reverts commit 0c8cb0b.
merge to latest develop
Debug mode capablility (#15)
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
nomerg2atm, new MOM6 dev/emc
This reverts commit 57236a6.
Update FV3, NEMS (#21)
Update2020 01 (#23)
Update NEMS,FV3,CICE (#28)
Add CCPP to UFS-S2S-model
Remove IPD tests and CCPP repro tests from the regression test system…
Feature/alt compsetrun (ufs-community#75)
the mediator restart name will be changed in a later commit
Collaborator
Author
|
This PR is ready for final RT testing and commit. My understanding is that it will follow on PR #213. |
fix tpn for dell-p3 in new configurations
Merged
Collaborator
Author
|
Tests are running on Orion, Dell-p3 and Hera. |
Collaborator
Author
|
I need to re-run the RTs. I had mistakenly left three of the exisiting tests commented out (2threads, decomp and satmedmf). |
Collaborator
Author
|
Ready for review. |
JessicaMeixner-NOAA
approved these changes
Oct 20, 2020
Collaborator
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
There are a lot of changes, but they all look good to me. Thanks for all of this @DeniseWorthen I know this was no small task but we'll all appreciate the end result!
junwang-noaa
approved these changes
Oct 21, 2020
binli2337
approved these changes
Oct 21, 2020
Collaborator
|
Just to add my 2 cents, I have been setting "stop_n=$FHMAX" in my script
and I haven't seen any problem.
The integration stopped at the right time and created the right history and
restart files.
…On Tue, Oct 20, 2020 at 11:04 PM Jun Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In parm/nems.configure.medcmeps_atm_ocn_ice.IN
<#204 (comment)>
:
> @@ -42,7 +42,7 @@ ICE_attributes::
ProfileMemory = false
OverwriteSlice = true
mesh_ice = @[MESHICE]
- stop_n = @[FHMAX]
+ stop_n = @[FV3_RESTART_H]
I agree. If we do need to set ICE integration length, it would be
"FHMAX-FHROT". In general, each subcomponent inherits the clock from top
level component to control integration time. So I think the "The only
function is to have the timing code inside of cice turn on and off" makes
sense to me. But we can make changes later.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYSFK6Y3I2DUWNPDHYLSLZFVLANCNFSM4R7U2HPQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Collaborator
Author
|
Thanks Moorthi. I was mistaken in my first statement about what stop_n does. It only controls the timers in CICE so it should work with pretty much any setting (other than 0 probably). |
DeniseWorthen
added a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Oct 26, 2020
Replaces current coupled tests, default vars and other files to implement low resolution tests from ufs-s2s-model in the unified repository. See ufs-s2s-model PR # 204 (ufs-community/ufs-s2s-model#204) and PR # 194 (ufs-community/ufs-s2s-model#194) for more detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleans up
default_varsto reflect new default test resolution of c96-1deg ocean and ice.Reproduces existing tests by adding non-default configurations (eg c96-1/4deg ocean and ice) explicitly
Removes many old settings in existing tests which are now defaults (eg. setting input_nml to the ccpp version).
Adds s2s tests to replicate existing c384-1/4 deg tests for the control, benchmark, benchmark+waves and c384mx025 frac grid configurations. Also replicates c96mx025 restart test. These tests are b4b with existing baselines.
Three MOM6 default settings have changed to match MOM6 defaults for the 1deg model.
MOM6 1deg does not have a river runoff file so
MOM6_RIVER_RUNOFFis now setFalseMOM6_REPRO_LAandMOM6_THERMO_SPANare nowFalse(the default MOM6 setting). The non-default use ofMOM6_THERMO_SPANare removed since testing showed that using the default setting was b4b.A new MOM6 setting
MOM6_USE_WAVES(defaultFalse) has been added in order to combine the wave and non-wave MOM input templatesSpecific notes
Issues Fixed (include github issue #):
ufs-weather issue #221
ufs-s2s issue #218
Follow-on ufs-s2s PR #194
Are changes expected to change answers?
Specific changes:
Testing performed:
Hashes used for testing:
Co-authored by: