Skip to content

[develop] Rename variables related to GFDLgrid-type grids #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsketefian merged 7 commits into from
Jun 27, 2022
Merged

[develop] Rename variables related to GFDLgrid-type grids #787

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29ad1a9
In WE2E test configuration files that use custom grids, move the defi…
gsketefian Jun 5, 2022
8050d4b
Corrections to comments in python plotting scripts.
gsketefian Jun 5, 2022
5ceb281
Rename GFDLgrid-related variables for clarity. Details below.
gsketefian Jun 13, 2022
6e44149
Rename files to reflect renaming of variables; edit comments for clar…
gsketefian Jun 13, 2022
cd2e6ae
Remove unnecessary symlink.
gsketefian Jun 14, 2022
b4f5b7e
Reduce the default wallclock time for the make_orog task. Details be…
gsketefian Jun 14, 2022
fc69f02
Remove outdated comments.
gsketefian Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/WE2E/test_configs/wflow_features/config.custom_ESGgrid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ LBC_SPEC_INTVL_HRS="3"
#
# Define custom grid.
#
POST_OUTPUT_DOMAIN_NAME="custom_ESGgrid"
GRID_GEN_METHOD="ESGgrid"

ESGgrid_LON_CTR="-97.5"
Expand All @@ -46,8 +47,6 @@ LAYOUT_X="8"
LAYOUT_Y="12"
BLOCKSIZE="13"

POST_OUTPUT_DOMAIN_NAME="custom_ESGgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
3 changes: 1 addition & 2 deletions tests/WE2E/test_configs/wflow_features/config.custom_GFDLgrid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ LBC_SPEC_INTVL_HRS="3"
#
# Define custom grid.
#
POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"
GRID_GEN_METHOD="GFDLgrid"

GFDLgrid_LON_T6_CTR="-97.5"
Expand Down Expand Up @@ -76,8 +77,6 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
3 changes: 1 addition & 2 deletions ...wflow_features/config.custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ LBC_SPEC_INTVL_HRS="3"
#
Comment thread
JeffBeck-NOAA marked this conversation as resolved.
# Define custom grid.
#
POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"
GRID_GEN_METHOD="GFDLgrid"

GFDLgrid_LON_T6_CTR="-97.5"
Expand Down Expand Up @@ -63,8 +64,6 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
3 changes: 1 addition & 2 deletions .../wflow_features/config.custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ LBC_SPEC_INTVL_HRS="3"
#
# Define custom grid.
#
POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"
GRID_GEN_METHOD="GFDLgrid"

GFDLgrid_LON_T6_CTR="-97.5"
Expand Down Expand Up @@ -63,8 +64,6 @@ LAYOUT_X="6"
LAYOUT_Y="6"
BLOCKSIZE="26"

POST_OUTPUT_DOMAIN_NAME="custom_GFDLgrid"

QUILTING="TRUE"
if [ "$QUILTING" = "TRUE" ]; then
WRTCMP_write_groups="1"
Expand Down
2 changes: 1 addition & 1 deletion ush/Python/plot_allvars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# David Wright Org: University of Michigan
#
# Instructions: Make sure all the necessary modules can be imported.
# Six command line arguments are needed:
# The following command line arguments are needed:
# 1. Cycle date/time in YYYYMMDDHH format
# 2. Starting forecast hour
# 3. Ending forecast hour
Expand Down
2 changes: 1 addition & 1 deletion ush/Python/plot_allvars_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# David Wright Org: University of Michigan
#
# Instructions: Make sure all the necessary modules can be imported.
# Seven command line arguments are needed:
# The following command line arguments are needed:
# 1. Cycle date/time in YYYYMMDDHH format
# 2. Starting forecast hour
# 3. Ending forecast hour
Expand Down