[develop] Rename variables related to GFDLgrid-type grids#787
Merged
gsketefian merged 7 commits intoJun 27, 2022
Conversation
…nition of the variable POST_OUTPUT_DOMAIN_NAME to at the beginning of the custom grid definition because it is really the name of the custom native grid.
gsketefian
changed the title
POST_OUTPUT_DOMAIN_NAME to start of custom grid definitionPOST_OUTPUT_DOMAIN_NAME to start of custom grid definition
gsketefian
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gspetro-NOAA,
jkbk2004,
mark-a-potts,
mkavulich,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
willmayfield
approved these changes
Jun 5, 2022
gsketefian
changed the title
POST_OUTPUT_DOMAIN_NAME to start of custom grid definitionPOST_OUTPUT_DOMAIN_NAME to start of custom grid definition
1) Rename GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES to GFDLgrid_USE_NUM_CELLS_IN_FILENAMES. 2) Rename GFDLgrid_RES to GFDLgrid_NUM_CELLS.
Reduce WTIME_MAKE_OROG from 1 hour to 20 minutes since on Hera, 1 hour causes the task to wait quite a while in the queue. This used to be 20 minutes but was changed to 1 hour because 20 minutes was not sufficient to complete the task on WCOSS_DELL_P3. Thus, reset it to 1 hour only in the machine file for WCOSS_DELL_P3.
gsketefian
changed the title
POST_OUTPUT_DOMAIN_NAME to start of custom grid definition
chan-hoo
approved these changes
Jun 15, 2022
JeffBeck-NOAA
approved these changes
Jun 17, 2022
willmayfield
approved these changes
Jun 22, 2022
Collaborator
willmayfield
left a comment
willmayfield
left a comment
There was a problem hiding this comment.
Approving with one comment.
| # GFDLgrid_NUM_CELLS: | ||
| # Number of grid cells in each of the two horizontal directions (x and | ||
| # y) on each tile of the parent global grid. Note that the name of this | ||
| # parameter is really a misnomer because although it has the stirng "RES" |
Collaborator
There was a problem hiding this comment.
Shouldn't the discussion of "RES" be removed if taking it out of the variable name? (Also there's a typo "stirng")
Collaborator
Author
There was a problem hiding this comment.
@willmayfield Yes, it should! I'll fix it.
gsketefian
added a commit
to ufs-community/ufs-srweather-app
that referenced
this pull request
Jun 27, 2022
## DESCRIPTION OF CHANGES: Rename experiment variables to match changes in PR #[787](ufs-community/regional_workflow#787) in `regional_workflow`. ## TESTS CONDUCTED: None needed. ## DEPENDENCIES: PR #[787](ufs-community/regional_workflow#787) in `regional_workflow`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
For clarity, rename variables related to GFDLgrid-type grids:
GFDLgrid_REStoGFDLgrid_NUM_CELLS.GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMEStoGFDLgrid_USE_NUM_CELLS_IN_FILENAMES.Related improvements:
link_fix.sh, remove creation of unnecessary symlink when using a GFDLgrid-type grid withGFDLgrid_USE_NUM_CELLS_IN_FILENAMESis set to"FALSE".POST_OUTPUT_DOMAIN_NAMEto the beginning of the custom grid definition because it is really the name of the custom native grid, and it's most appropriate to place that at the beginning of the grid definition section.WTIME_MAKE_OROGfrom 1 hour to 20 minutes since on Hera, 1 hour causes the task to wait quite a while in the queue. This used to be 20 minutes but was changed to 1 hour because 20 minutes was not sufficient to complete the task onWCOSS_DELL_P3. Thus, reset it to 1 hour only in the machine file forWCOSS_DELL_P3.TESTS CONDUCTED:
Ran the four WE2E tests that use custom grids (listed below) on Hera. All were successful.
custom_ESGgridcustom_GFDLgridcustom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE(previouslycustom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE)custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_TRUE(previouslycustom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE)DEPENDENCIES:
PR #310 in
ufs-srweather-app.DOCUMENTATION:
Updates to documentation are in PR #310 in
ufs-srweather-app.