Changes to Logging and Initialization of the CLM Lake Model#92
Conversation
1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model.
SamuelTrahanNOAA
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
tanyasmirnova
as code owners
|
This wasn't the final version of Tanya's changes. I'm retesting her final version now, on top of the latest ufs-weather-model. |
tanyasmirnova
left a comment
tanyasmirnova
left a comment
There was a problem hiding this comment.
@SamuelTrahanNOAA Thank you, Sam, for making a PR with these modification to the CLM lake initialization.
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
I don't see any issues from a CCPP point of view. There is a lot more debugging output, of course, but it looks to be controlled by debug flags, so it shouldn't be an issue.
The amount of output from clm_lake_debug=.true. was so large that it was useless. Tanya split it up and added a separate flag to enable the super-verbose prints. |
| wght1 = 1.0_kind_lake - wght2 | ||
|
|
||
| if(LAKEDEBUG .and. me==0) then | ||
| if(debug_print ) then |
There was a problem hiding this comment.
Do we want to do this on all processors?
There was a problem hiding this comment.
That lets us confirm the value is the same, and correct, on all ranks.
…te "v3" file), correct misspelled pages "shemes" --> "schemes"
SamuelTrahanNOAA
requested review from
JongilHan66,
haiqinli and
mzhangw
as code owners
|
@SamuelTrahanNOAA regression testing is finished on UFS-WM PR #1844. We can begin the merging process and start with this sub-component ccpp-physics PR. |
A fine idea. Unfortunately, I lack access to press the "merge" button. We shall have to wait for a code manager to resurface. |
|
Hello. @dustinswales @grantfirl would you please merge this PR? |
|
@zach1221 Done. Sorry for the delay. |
@dustinswales Alright, understood. Thank you for helping! |
|
@dustinswales Thanks for stepping in, sorry I missed the merge request here. |
8 participants
This is the work of @tanyasmirnova to fix some initialization issues in the CLM Lake Model. Initialization appears to work correctly without fractional ice. There are some lingering issues with fractional ice initialization that we're working on.
Changes: