UFS-dev PR#92#1034
Merged
Merged
Conversation
1. Use ice thickness hice(i) to find the level in the lake where ice is zero. 2. Do not allow lake temperature to be below freezing point if there is no ice. 3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes. 4. Added flag to turn on debug print statements in the CLM lake model.
…te "v3" file), correct misspelled pages "shemes" --> "schemes"
Few small fixes to Thompson MP
grantfirl
requested review from
JongilHan66,
Qingfu-Liu and
dustinswales
as code owners
grantfirl
requested review from
AndersJensen-NOAA,
RuiyuSun,
SamuelTrahanNOAA,
gthompsnWRF,
haiqinli,
mzhangw and
tanyasmirnova
as code owners
grantfirl
requested review from
mkavulich
and removed request for
AndersJensen-NOAA,
JongilHan66,
RuiyuSun,
SamuelTrahanNOAA,
dustinswales,
gthompsnWRF,
haiqinli,
mzhangw and
tanyasmirnova
Qingfu-Liu
approved these changes
Nov 3, 2023
mkavulich
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#92
Contains changes from #1033 until it is merged.