Skip to content

update GF for RRFS 2023 HWT SFE#64

Merged
grantfirl merged 6 commits into
ufs-community:ufs/devfrom
haiqinli:ufs/dev-gf
Apr 20, 2023
Merged

update GF for RRFS 2023 HWT SFE#64
grantfirl merged 6 commits into
ufs-community:ufs/devfrom
haiqinli:ufs/dev-gf

Conversation

@haiqinli
Copy link
Copy Markdown
Collaborator

1). A update of the Grell-Freitas (GF) convection for RRFS;
2). A update of RUC LSM to use BNU soil property for RRFS;
3). This is an urgent PR for RRFS 2023 HWT SFE, which will start on May 1st, 2023;
4). The regression test run has been successfully done on Hera with Intel and GNU compilers.

@tanyasmirnova
Copy link
Copy Markdown
Collaborator

@haiqinli Haiqin, thank you very much for adding my change to soil parameters.

@haiqinli
Copy link
Copy Markdown
Collaborator Author

@tanyasmirnova You are welcome.

Comment thread physics/cu_gf_deep.F90 Outdated
@yangfanglin
Copy link
Copy Markdown
Collaborator

@grantfirl Grant, It appears that Chunxi Zhang is still automatically designated as a reviewer for may PRs and Issues. Can this the updated ? Please replace Chunxi Zhang with Qingfu Liu.

Comment thread physics/cu_gf_deep.F90 Outdated
@grantfirl
Copy link
Copy Markdown
Collaborator

grantfirl commented Apr 14, 2023

@grantfirl Grant, It appears that Chunxi Zhang is still automatically designated as a reviewer for may PRs and Issues. Can this the updated ? Please replace Chunxi Zhang with Qingfu Liu.

@yangfanglin Yes. I'll updated the CODEOWNERS file and ask @haiqinli to include it in this PR.

@grantfirl grantfirl requested a review from Qingfu-Liu April 14, 2023 17:47
Comment thread physics/cu_gf_deep.F90 Outdated
Comment thread physics/cu_gf_driver.meta Outdated
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comments from me. @dustinswales @Qingfu-Liu Since this is high-priority, please review when you get a chance.

@Qingfu-Liu
Copy link
Copy Markdown
Collaborator

I just went through the code, and everything looks good. Grant already suggested the minor changes.

Comment thread physics/cu_gf_driver_post.F90 Outdated
Comment thread physics/cu_gf_driver_post.F90
Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions.

@grantfirl
Copy link
Copy Markdown
Collaborator

@haiqinli Could you please merge haiqinli#1 to update the CODEOWNERS file?

@haiqinli
Copy link
Copy Markdown
Collaborator Author

@grantfirl Sure, I will merge this CODEOWNERS file.

update CODEOWNERS to replace Chunxi with Qingfu
@jkbk2004
Copy link
Copy Markdown

All tests are done at ufs-community/ufs-weather-model#1713 @haiqinli resolve the conversations @grantfirl can you merge this pr?

@grantfirl grantfirl merged commit 494356c into ufs-community:ufs/dev Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants