Smoke, dust, and MYNN updates#54
Conversation
SamuelTrahanNOAA
requested review from
ChunxiZhang-NOAA,
Qingfu-Liu,
dustinswales and
grantfirl
as code owners
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks good.
Some minor suggestions.
…e Dom and add Dustin in CMakeLists.txt authors
Remove MYNN SFC logic from noahmpdrv.F90 and fix CMakeLists.txt authors
|
@dustinswales - I just merged a branch from @haiqinli that should resolve the problems you found, other than the one you said should be fixed in a follow-up PR instead. |
|
Nice work @haiqinli and @joeolson42 -- only minor comments really. There is room for computational improvement with dividing by physical constants within N-nested loops, but I'm not going to hold up your progress for that (and it might be optimized by the compiler anyway?). I'll approve once comments are addressed. |
|
@grantfirl - @haiqinli is preparing some changes to address your comments and I'll merge them from his branch as soon as possible. |
|
@grantfirl - I just merged changes from @haiqinli to fix the problems you found, and I also updated to the top of ufs/dev. |
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Thanks for the prompt updates @haiqinli @SamuelTrahanNOAA .
|
@dustinswales You'll need to re-review since you requested changes. |
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks good. Thanks for making the requested changes.
|
@grantfirl test was one on ufs-community/ufs-weather-model#1658. we can merge in this pr. |
sync with the latest ufs/dev branch
8 participants
RRFS-Smoke is improved, cleaned, and rebranded as RRFS-SD. Now with smoke, dust, and coarsepm tracer handling, it adds dry deposition velocity to MYNN-EDMF, updates the smoke/dust direct and indirect feedback. There are bug fixes: switch to non-aerosol-aware in the GF scheme and correct emission bug in FENGSHA.
Also included are MYNN updates from #43
These changes are from @haiqinli and @joeolson42.
Related issue: ufs-community/ufs-weather-model#1659