[production/GFS.v17] Reduce number of goto statements and fix RRTMGP warning#370
Merged
rhaesung merged 2 commits intoApr 8, 2026
Merged
Conversation
dpsarmie
requested review from
AnningCheng-NOAA,
Qingfu-Liu,
RuiyuSun,
andrewgettelman,
dustinswales,
grantfirl,
mzhangw,
rhaesung and
tanyasmirnova
as code owners
This was referenced Apr 7, 2026
dustinswales
approved these changes
Apr 7, 2026
AnningCheng-NOAA
approved these changes
Apr 8, 2026
Collaborator
AnningCheng-NOAA
left a comment
AnningCheng-NOAA
left a comment
There was a problem hiding this comment.
looks fine with me
RuiyuSun
approved these changes
Apr 8, 2026
Author
|
Testing was completed on this PR. CMs can go ahead and merge whenever they are ready to do so. |
rhaesung
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
This PR is for the GFSv17 production branch of CCPP Physics. It will update the RTE-RRTMGP model hash to the production/GFS.v17 branch on that repo. That production branch has added changes that address the compile warning that is described in #322 . The change proposed in the issue was applied as part of EE2 compliance for GFS operations.
This PR also brings in select changes from #367 as part of EE2 compliance. Only files for subroutines that are not being used by the GFSv17 configuration were imported out of an abundance of caution, even though #367 did not change baselines in the UFSWM.
Tests Conducted:
Tests were performed using the UFSWM regression test suite on baselines that I maintain for the production/GFS.v17 branch. These changes were tested on Ursa and WCOSS2.
Dependencies:
None. The RRTMGP branch was already created on the NCAR repo.
Documentation:
None
Issue (optional):
No issue was made for the production branch. The issues that are currently open are for when the changes are pushed to develop.
Contributors (optional):
Changes were taken from #367 and the proposed solution detailed in #322