Physics changes for ccpp framework update#311
Merged
rhaesung merged 9 commits intoNov 13, 2025
Conversation
… into feature/ccpp_framework_update
… into feature/ccpp_framework_update
dustinswales
requested review from
Qingfu-Liu,
RuiyuSun,
grantfirl and
rhaesung
as code owners
14 tasks
Collaborator
|
@dustinswales The metadata changes look fine of course, so I'm happy to approve, but @climbfuji mentioned that the RRTMGP offending interstitial variable problem should be addressed here, which I don't see. I'm assuming that therefore this is a WIP? |
rhaesung
approved these changes
Sep 19, 2025
RuiyuSun
approved these changes
Sep 19, 2025
Collaborator
Author
|
@grantfirl The RRTMGP fix is in UFSATM |
Collaborator
Thanks for the clarification. I'm glad that the offending variable was found! |
grantfirl
approved these changes
Sep 23, 2025
Qingfu-Liu
approved these changes
Sep 23, 2025
|
Testing on #2881 is complete, please continue with merging. Thank you. |
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Physics changes for ccpp framework update.
Tests Conducted:
UWM RTs on URSA pass.
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
Contributors (optional):
@climbfuji