Skip to content

UFSATM changes for ccpp framework update#1006

Merged
jkbk2004 merged 31 commits into
NOAA-EMC:developfrom
dustinswales:feature/ccpp_framework_update
Nov 13, 2025
Merged

UFSATM changes for ccpp framework update#1006
jkbk2004 merged 31 commits into
NOAA-EMC:developfrom
dustinswales:feature/ccpp_framework_update

Conversation

@dustinswales
Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales commented Sep 8, 2025

Description

Host-side changes to accommodate CCPP Framework updates.

  • Replace scalars in metadata dimensions with variables (e.g. 0:number_layers-> constant_zero:number_layers)
  • Provide complete metadata declarations for variables (e.g phy_f2d and phy_f3d in GFS_typedefs.F90)
  • Create/destroy interstitial fields within run step.

Issue(s) addressed

#1005 @climbfuji

Testing

Tested on URSA with GNU and Intel.
All tests pass.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Nov 5, 2025

Could we get reviews on this PR so that we can begin processing its parent WM PR #2881 next?

@climbfuji
Copy link
Copy Markdown
Collaborator

Could we get reviews on this PR so that we can begin processing its parent WM PR #2881 next?

@dustinswales is currently not available, we'll need him to address the merge conflicts and any reviewer comments.

@grantfirl
Copy link
Copy Markdown
Collaborator

grantfirl commented Nov 5, 2025

Could we get reviews on this PR so that we can begin processing its parent WM PR #2881 next?

@dustinswales is currently not available, we'll need him to address the merge conflicts and any reviewer comments.

I have push privileges on @dustinswales 's fork, so I addressed the merge conflicts when updating to the latest develop. If there are reviewer comments, I may be able to help with those too, depending on the comments.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@grantfirl Great! At the moment, there aren't any reviewer comments, but there also aren't any reviews. ;)

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes are from a corresponding PR for NEPTUNE, all good.

@rhaesung
Copy link
Copy Markdown
Contributor

@grantfirl @dustinswales ufs-community/ccpp-physics#311 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@6382d61) and revert .gitmodules file.

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl @dustinswales ufs-community/ccpp-physics#311 has been merged. Please update the submodule pointer for ccpp-physics (ufs-community/ccpp-physics@6382d61) and revert .gitmodules file.

Finished. Ready for final review/merge.

@jkbk2004 jkbk2004 merged commit 09ca999 into NOAA-EMC:develop Nov 13, 2025
8 checks passed
@dustinswales dustinswales deleted the feature/ccpp_framework_update branch May 20, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants