fix grv function for argument value#131
Merged
dustinswales merged 3 commits intoNov 20, 2023
Merged
Conversation
DeniseWorthen
requested review from
Qingfu-Liu,
XuLi-NOAA,
dustinswales and
grantfirl
as code owners
This was referenced Nov 15, 2023
XuLi-NOAA
approved these changes
Nov 15, 2023
Collaborator
XuLi-NOAA
left a comment
XuLi-NOAA
left a comment
There was a problem hiding this comment.
The changes make sense and are fine to me.
grantfirl
approved these changes
Nov 15, 2023
Qingfu-Liu
approved these changes
Nov 15, 2023
|
Hi, @grantfirl @Qingfu-Liu , we are finished testing on UFS-WM PR #2001 . Please merge this PR for us, if you're able. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will change baselines of most UWM RTs. Logs will be posted in the associated UWM PR ufs-community/ufs-weather-model/pull/2001