Skip to content

fix grv function used by NST#722

Merged
jkbk2004 merged 8 commits into
NOAA-EMC:developfrom
DeniseWorthen:bugfix/grvfunction
Nov 20, 2023
Merged

fix grv function used by NST#722
jkbk2004 merged 8 commits into
NOAA-EMC:developfrom
DeniseWorthen:bugfix/grvfunction

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Nov 15, 2023

Description

Changes argument used by grv function.

Issue(s) addressed

Testing

Dependencies

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Can this PR be combined with #719?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Since this changes so many baselines, I'd prefer to have it go alone. The other PR is not breaking anything but I want to make a few more changes.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Since this changes so many baselines, I'd prefer to have it go alone. The other PR is not breaking anything but I want to make a few more changes.

OK. Thanks. I should have looked at corresponding UFSWM PRs to see that one PR changes baselines and other doesn't.

@zach1221
Copy link
Copy Markdown
Collaborator

@jkbk2004 we have approval here and are ready to merge.

@jkbk2004 jkbk2004 merged commit cd2c3b7 into NOAA-EMC:develop Nov 20, 2023
@DeniseWorthen DeniseWorthen deleted the bugfix/grvfunction branch April 10, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grv function used by NST assumes wrong argument

5 participants