NCAR/main PR #967 (Bugfix and optimization of prognostic closure for the P8 physics suit)#13
Merged
dustinswales merged 5 commits intoOct 11, 2022
Conversation
Bugfix and optimization of prognostic closure for the P8 physics suite
dustinswales
requested review from
ChunxiZhang-NOAA and
grantfirl
as code owners
grantfirl
approved these changes
Oct 6, 2022
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
I previously reviewed this when it went into NCAR/main. Approved.
ChunxiZhang-NOAA
approved these changes
Oct 6, 2022
16 tasks
|
@ChunxiZhang-NOAA Can we merge in this PR, since all tests are done on ufs-wm pr #1451 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes were made by @lisa-bengtsson.
UFS RTs passed on Hera/Cheyenne with Intel/GNU.
From NCAR #967:
This PR corrects a bug when using the prognostic closure (progsigma = true) to compute the q-tendency due to microphysics even if the diagnostic flags are false. It also optimizes the cloudbase massflux value for shallow and deep convection to work with the overall P8 physics suite.
New baselines are needed for the test: control_c384_progsigma
This update does not change the results in the control tests.
###issues
It addresses the issue: NCAR#960
###dependencies
NCAR#967