Bugfix and optimization of prognostic closure for the P8 physics suite#967
Merged
Conversation
lisa-bengtsson
requested review from
ChunxiZhang-NOAA,
JongilHan66,
SamuelTrahanNOAA,
climbfuji,
grantfirl,
mkavulich,
mzhangw and
panll
as code owners
JongilHan66
approved these changes
Sep 15, 2022
Contributor
JongilHan66
left a comment
JongilHan66
left a comment
There was a problem hiding this comment.
I approve the bug correction and the prognostic updraft fraction optimization.
Collaborator
|
@ChunxiZhang-NOAA This PR seems like it should be targeted toward the ufs-dev branch to me. What do you think? @lisa-bengtsson I'm assuming that you started this work from the top of NCAR/main, correct? |
Collaborator
Author
|
@grantfirl yes that is correct. |
Contributor
|
@grantfirl Looks like this PR only impacts one RT control_c384_progsigma and will not change other RTs. This PR is not for operational applications in short term. So I think it can stay here at NCAR/main. |
dustinswales
approved these changes
Sep 15, 2022
grantfirl
approved these changes
Sep 15, 2022
ChunxiZhang-NOAA
approved these changes
Sep 15, 2022
This was referenced Sep 26, 2022
dustinswales
pushed a commit
to ufs-community/ccpp-physics
that referenced
this pull request
Oct 11, 2022
NCAR/main PR NCAR#967 (Bugfix and optimization of prognostic closure for the P8 physics suit)
bluefinweiwei
added a commit
to bluefinweiwei/ccpp-physics
that referenced
this pull request
Oct 12, 2022
…re for the P8 physics suite NCAR#967" https://github.com/NCAR/ccpp-physics/pull/967/files modified: GFS_MP_generic_pre.F90 modified: GFS_MP_generic_pre.meta modified: progsigma_calc.f90 modified: samfdeepcnv.f modified: samfshalcnv.f
bluefinweiwei
added a commit
to bluefinweiwei/ccpp-physics
that referenced
this pull request
Oct 12, 2022
…re for the P8 physics suite NCAR#967" https://github.com/NCAR/ccpp-physics/pull/967/files modified: GFS_MP_generic_pre.F90 modified: GFS_MP_generic_pre.meta modified: progsigma_calc.f90 modified: samfdeepcnv.f modified: samfshalcnv.f modified: physics/GFS_MP_generic_pre.F90 modified: physics/GFS_MP_generic_pre.meta modified: physics/progsigma_calc.f90 modified: physics/samfdeepcnv.f modified: physics/samfshalcnv.f
bluefinweiwei
added a commit
to DTC-phytne/ccpp-physics
that referenced
this pull request
Oct 13, 2022
* Adopt progsigma "Add prognostic cumulus closure description in saSAS NCAR#903" https://github.com/NCAR/ccpp-physics/pull/903/files modified: GFS_DCNV_generic_post.F90 modified: GFS_DCNV_generic_post.meta modified: GFS_DCNV_generic_pre.F90 modified: GFS_DCNV_generic_pre.meta modified: GFS_MP_generic_post.F90 modified: GFS_MP_generic_post.meta modified: GFS_SCNV_generic_post.F90 modified: GFS_SCNV_generic_post.meta modified: GFS_SCNV_generic_pre.F90 modified: GFS_SCNV_generic_pre.meta modified: GFS_suite_interstitial_3.F90 modified: GFS_suite_interstitial_3.meta new file: progsigma_calc.f90 modified: samfdeepcnv.f modified: samfdeepcnv.meta modified: samfshalcnv.f modified: samfshalcnv.meta modified: satmedmfvdifq.F modified: satmedmfvdifq.meta * Adopt bugfixed progsigma "Bugfix and optimization of prognostic closure for the P8 physics suite NCAR#967" https://github.com/NCAR/ccpp-physics/pull/967/files modified: GFS_MP_generic_pre.F90 modified: GFS_MP_generic_pre.meta modified: progsigma_calc.f90 modified: samfdeepcnv.f modified: samfshalcnv.f modified: physics/GFS_MP_generic_pre.F90 modified: physics/GFS_MP_generic_pre.meta modified: physics/progsigma_calc.f90 modified: physics/samfdeepcnv.f modified: physics/samfshalcnv.f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug when using the prognostic closure (progsigma = true) to compute the q-tendency due to microphysics even if the diagnostic flags are false. It also optimizes the cloudbase massflux value for shallow and deep convection to work with the overall P8 physics suite.
New baselines are needed for the test: control_c384_progsigma
This update does not change the results in the control tests.
It addresses the issue: #960