Remove nine 3D arrays from CLM Lake model

[SamuelTrahanNOAA]

There are nine 3D arrays in CLM Lake that are constant. Seven of them are 2D arrays copied to all vertical levels. All are cheap to calculate.

This PR removes all nine arrays. When the numbers are needed, they're recalculated.

To do this, I had to add a 2D array: the lakedepth before correction.

• fixes CLM Lake restarts nine 3D fields that are constant #112

[Qingfu-Liu]

@SamuelTrahanNOAA Can you double check line 554 in file physics/clm_lake.f90?
do c = 2,column
z_lake(c,:) = z_lake(1,:)
dz_lake(c,:) = z_lake(1,:) !line 554
enddo

[SamuelTrahanNOAA]

Can you double check line 554 in file physics/clm_lake.f90?
do c = 2,column
z_lake(c,:) = z_lake(1,:)
dz_lake(c,:) = z_lake(1,:) !line 554
enddo

The "column" parameter is always 1, so the program never enters that loop. However, I fixed it anyway.

[Qingfu-Liu]

@sam Trahan ***@***.***> Yes, you are right, the column parameter c is always 1. Thanks

…

On Thu, Sep 28, 2023 at 12:11 PM Samuel Trahan (NOAA contractor) < ***@***.***> wrote: Can you double check line 554 in file physics/clm_lake.f90? do c = 2,column z_lake(c,:) = z_lake(1,:) dz_lake(c,:) = z_lake(1,:) !line 554 enddo The "column" parameter is always 1, so the program never enters that loop. However, I fixed it anyway. — Reply to this email directly, view it on GitHub <#113 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGTS6UXR3PIY7Z33QKQVNT3X4WOR5ANCNFSM6AAAAAA5J7D7RU> . You are receiving this because your review was requested.Message ID: ***@***.***>