Remove nine 3D arrays from CLM Lake model#705
Closed
SamuelTrahanNOAA wants to merge 2 commits into
Closed
Conversation
35 tasks
SamuelTrahanNOAA
changed the title
SamuelTrahanNOAA
added a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Sep 29, 2023
jkbk2004
pushed a commit
that referenced
this pull request
Oct 3, 2023
…sics, and string length mismatch in dycore plus PR #705 and #699 (#695) * GFDL_atmos_cubed_sphere: consistent string lengths in array * stop FV3_HRRR_c3 from crashing with gnu debug * in dycore, initialize srf_wnd_var2 and tracers_var3 arrays * Write netcdf axis variables using the same real kind as data variables * "GF radar reflectivity, dust bug fix, C3 updates, more fluxes output" * Fix race condition in GFS_phys_time_vary.fv3.F90 error detection * More bug fixes to GFS_phys_time_vary.fv3.F90: 1. detect empty errmsg from subroutines 2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90 * initialize errmsg & errflg in noahmp_tables.f90 * only read h2odata, ozdata and noahmp table when they are needed * remove all constant 3D variables from clm lake * calculate clm lake constants only once per i loop --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
Collaborator
|
Merged via #695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are nine 3D arrays in CLM Lake that are constant. Seven of them are 2D arrays copied to all vertical levels. All are cheap to calculate.
This PR removes all nine arrays. When the numbers are needed, they're recalculated.
To do this, I had to add a 2D array: the lakedepth before correction.
Issue(s) addressed
Testing
How were these changes tested?
A 3km RRFS case was run, removing one array at a time until all nine were gone.
What compilers / HPCs was it tested with?
Hera intel & gnu.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Existing tests are sufficient.
Have the ufs-weather-model regression test been run? On what platform?
Hera
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
Yes.
Please commit the regression test log files in your ufs-weather-model branch
Done.
Dependencies