Skip to content

Change a setting parameter of the NSST model in UFS_UTILS to be consistent with UFS(fv3atm) #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianCurtis-NOAA merged 2 commits into from
Oct 9, 2025
Merged

Change a setting parameter of the NSST model in UFS_UTILS to be consistent with UFS(fv3atm) #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6da352
commit changes in surface.F90 to handle xz maximum is 20
XuLi-NOAA Oct 2, 2025
e25875d
commit a parameter change from 30 to 20 for a UFS_UTILS test: chgres_…
XuLi-NOAA Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sorc/chgres_cube.fd/surface.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2679,7 +2679,7 @@ subroutine nst_land_fill
integer(esmf_kind_i8), pointer :: mask_ptr(:,:)
integer :: rc,i
integer, PARAMETER :: num_nst_fields_minus2 = 16
integer, PARAMETER :: xz_fill = 30.0
integer, PARAMETER :: xz_fill = 20.0
integer, PARAMETER :: nst_fill = 0.0

real(esmf_kind_r8), pointer :: data_ptr(:,:)
Expand Down Expand Up @@ -2738,6 +2738,7 @@ subroutine nst_land_fill

where(mask_ptr == 0) data_ptr = xz_fill ! all land
where(fice_ptr > 0.0) data_ptr = xz_fill ! points with some ice
where(data_ptr > xz_fill ) data_ptr = xz_fill ! force xz = 20 when it is greater than 20 (due to fv3atm code change)

do i = 1,num_nst_fields_minus2

Expand Down
4 changes: 2 additions & 2 deletions tests/chgres_cube/ftst_surface_nst_landfill.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ program surface_nst_landfill
-999.9, -999.9, -999.9, -999.9/),(/i_target,j_target/))

xz_correct = reshape((/-999.9, -999.9, -999.9, -999.9, &
-999.9, 30.0, 30.0, -999.9, &
-999.9, 30.0, 30.0, -999.9, &
-999.9, 20.0, 20.0, -999.9, &
-999.9, 20.0, 20.0, -999.9, &
-999.9, -999.9, -999.9, -999.9/),(/i_target,j_target/))

nst_bundle = ESMF_FieldBundleCreate(name="nst_bundle", fieldlist= &
Expand Down