Skip to content

Change a setting parameter of the NSST model in UFS_UTILS to be consistent with UFS(fv3atm)#1108

Merged
BrianCurtis-NOAA merged 2 commits into
ufs-community:developfrom
XuLi-NOAA:chgres_xz
Oct 9, 2025
Merged

Change a setting parameter of the NSST model in UFS_UTILS to be consistent with UFS(fv3atm)#1108
BrianCurtis-NOAA merged 2 commits into
ufs-community:developfrom
XuLi-NOAA:chgres_xz

Conversation

@XuLi-NOAA
Copy link
Copy Markdown
Contributor

@XuLi-NOAA XuLi-NOAA commented Oct 7, 2025

DESCRIPTION OF CHANGES:

A NSST model parameter, the maximum value of the diurnal warming layer thickness, z_w_max, has been reduced from 30 to 20 meters in 2021 in UFS (fv3atm) code, but z_w_max or xz_fill in UFS_UTILS is still set to be 30 in the chgres_cube utility of in UFS_UTILS. This PR is to change it to be 20 in UFS_UTILS as well to be consistent with UFS.

The code has been modifed and tested, and the result is as expected.

See https://docs.google.com/document/d/1Fl_rw_ski4cbP70I601uHhW7KNSwGB20Nf3UlJnsve4/edit?tab=t.0 for the details of the concern and solution.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (e25875d)
    • Orion:
    • Jet:
    • Ursa:
    • Hercules:
    • WCOSS2:
  • Compile branch on Ursa using GNU.
  • Compile branch in 'Debug' mode on WCOSS2.
  • Compile with Doxygen on any machine with no errors.
  • Run unit tests locally on any Tier 1 machine.
  • Run relevant consistency tests locally on all Tier 1 machines. (e25875d)
    • Orion:
    • Jet:
    • Ursa:
    • Hercules:
    • WCOSS2:

Optional test.

  • Run full set of chgres_cube consistency tests on Ursa.

Describe any additional tests performed.

DEPENDENCIES:

  • None

DOCUMENTATION:

All new and updated source code must be documented with Doxygen.

  • Doxygen is updated.

If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.

ISSUE:

Fixes #1107

CONTRIBUTORS (optional):

  • None

@RuiyuSun RuiyuSun added this to GFS v17 Oct 7, 2025
@JessicaMeixner-NOAA JessicaMeixner-NOAA moved this to Todo in GFS v17 Oct 8, 2025
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@XuLi-NOAA
Copy link
Copy Markdown
Contributor Author

Looks like the test that uses old xz fill values needs to be updated as well: https://github.com/XuLi-NOAA/UFS_UTILS/blob/f6da3526adae96a5c01cb4d8df0abbd95d04c04d/tests/chgres_cube/ftst_surface_nst_landfill.F90#L146-L147

Where is this test in UFS_UTILS? For example, in which directory as follows:

/scratch3/NCEPDEV/global/Xu.Li/chgres_xz
(base) bash-4.4$ ls
CMakeLists.txt LICENSE.md README.md VERSION build_all.sh ccpp-physics ci cmake docs driver_scripts fix modulefiles parm reg_tests sorc tests ush util

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

tests/chgres_cube/ftst_surface_nst_landfill.F90

Lines 146-147

@XuLi-NOAA
Copy link
Copy Markdown
Contributor Author

tests/chgres_cube/ftst_surface_nst_landfill.F90

Lines 146-147

I see it. Yes, you are right, the 30 need to be changed to be 20 for this test of UFS_UTILS.

@XuLi-NOAA
Copy link
Copy Markdown
Contributor Author

tests/chgres_cube/ftst_surface_nst_landfill.F90
Lines 146-147

I see it. Yes, you are right, the 30 need to be changed to be 20 for this test of UFS_UTILS.

Brian,

I have commited the change (30 to 20 for this test) to my branch: chgres_xz

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Brian.Curtis@ufe02 /scratch4/NCEPDEV/nems/Brian.Curtis/git/XuLi-NOAA/UFS_UTILS/reg_tests/chgres_cube $ cat summary.log
consistency.log01:<<< C96 FV3 RESTART TEST FAILED. >>>
consistency.log02:<<< C192 FV3 HISTORY TEST FAILED. >>>
consistency.log03:<<< C96 FV3 GAUSSIAN NETCDF TEST FAILED. >>>

We expect these to fail since they are impacted by the changes in this PR. (all show changes in the xz variable)

This is consistent on all other systems as well.

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 6c05801 into ufs-community:develop Oct 9, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in UFS_UTILS v1.15.0 Oct 9, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in GFS v17 Oct 9, 2025
DavidHuber-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this pull request Oct 28, 2025
This includes updates for an NSST parameter to be
consistent with the ufs-weather-model
(ufs-community/UFS_UTILS#1108) from @XuLi-NOAA.

Resolves #4177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

inconsistent upper bound value for XZ in the UFS_UTILS and UFS

4 participants