Change a setting parameter of the NSST model in UFS_UTILS to be consistent with UFS(fv3atm)#1108
Conversation
|
Looks like the test that uses old xz fill values needs to be updated as well: https://github.com/XuLi-NOAA/UFS_UTILS/blob/f6da3526adae96a5c01cb4d8df0abbd95d04c04d/tests/chgres_cube/ftst_surface_nst_landfill.F90#L146-L147 |
Where is this test in UFS_UTILS? For example, in which directory as follows: /scratch3/NCEPDEV/global/Xu.Li/chgres_xz |
|
tests/chgres_cube/ftst_surface_nst_landfill.F90 Lines 146-147 |
I see it. Yes, you are right, the 30 need to be changed to be 20 for this test of UFS_UTILS. |
Brian, I have commited the change (30 to 20 for this test) to my branch: chgres_xz |
|
Brian.Curtis@ufe02 /scratch4/NCEPDEV/nems/Brian.Curtis/git/XuLi-NOAA/UFS_UTILS/reg_tests/chgres_cube $ cat summary.log We expect these to fail since they are impacted by the changes in this PR. (all show changes in the xz variable) This is consistent on all other systems as well. |
This includes updates for an NSST parameter to be consistent with the ufs-weather-model (ufs-community/UFS_UTILS#1108) from @XuLi-NOAA. Resolves #4177
DESCRIPTION OF CHANGES:
A NSST model parameter, the maximum value of the diurnal warming layer thickness, z_w_max, has been reduced from 30 to 20 meters in 2021 in UFS (fv3atm) code, but z_w_max or xz_fill in UFS_UTILS is still set to be 30 in the chgres_cube utility of in UFS_UTILS. This PR is to change it to be 20 in UFS_UTILS as well to be consistent with UFS.
The code has been modifed and tested, and the result is as expected.
See https://docs.google.com/document/d/1Fl_rw_ski4cbP70I601uHhW7KNSwGB20Nf3UlJnsve4/edit?tab=t.0 for the details of the concern and solution.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Optional test.
Describe any additional tests performed.
DEPENDENCIES:
DOCUMENTATION:
All new and updated source code must be documented with Doxygen.
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE:
Fixes #1107
CONTRIBUTORS (optional):