Prevent selection deletions at the end of list items from joining lists #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If starting a selection at the end of a list item, then pressing delete, the selected text wasn't being deleted, but instead the following list item was joined to the end. Now the selected text will be deleted. Joining will only occur if the selection spans multiple nodes or it's collapsed.
🦋 Changeset detectedLatest commit: 8f7daae The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nperez0111
approved these changes
Nov 25, 2024
nperez0111
pushed a commit
that referenced
this pull request
Nov 26, 2024
…s from joining lists (#5863) If starting a selection at the end of a list item, then pressing delete, the selected text wasn't being deleted, but instead the following list item was joined to the end. Now the selected text will be deleted. Joining will only occur if the selection spans multiple nodes or it's collapsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Previously the text wasn't being deleted, but the following list item was being joined (see the testing videos within Verification Steps)
NOTE: The fix might be better suited to the
isAtEndOfNodefunction from@tiptap/core- however because that's exposed it might result in unintended regressions out in the wild.Implementation Approach
Traced the ListKeymap delete handlers and debugged guard statements that were trying to avoid the
joinItemForwardcommand.Testing Done
All initial tests passed & performed manual testing of the
http://localhost:3000/preview/Extensions/ListKeymapdemo.Verification Steps
Attempted a deletion of text, starting from the end of a node - then going backwards, before & after the change:
Before
List.keymap.before.mp4
After
List.keymap.after.mp4
Checklist