fix: #5851 - While setting content directly while using CharacterCount with limit is not obeyed #5853
Conversation
…nt with limit is not obeyed #5851
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| if (currentCharCount > limit) { | ||
| const text = doc.textBetween(0, doc.content.size, undefined, ' ') | ||
| const trimmedContent = text.slice(0, limit) | ||
|
|
||
| // Replace the entire document content | ||
| editor.commands.setContent(trimmedContent) | ||
|
|
||
| // Add a console warning | ||
| console.warn(`[CharacterCount] Initial content exceeded limit of ${limit} characters. Content was automatically trimmed.`) |
There was a problem hiding this comment.
I'd prefer to leave this to the plugin, by issuing a transaction or allowing a transaction through which would execute the existing logic.
Prevents drift between the two implementations. Especially since this implementation does not even do the same thing as the existing implementation, you are slicing based on text alone while the existing implementation is slicing the whole range by counted chars
Fixes #5851
2024-11-21.at.17.32.58.-.Peach.Butterfly.mp4