Font-family extension: Prevent removal of quotes in parseHTML #5828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Font-family extension: Prevent removal of quotes in
parseHTML
Removing quotes in
font-family
parsing can result in invalid HTML when using font names that contain both spaces and numbers (e.g., "Exo 2").Implementation Approach
Initially attempted to add quotes in
renderHTML
, but realized the issue originated inparseHTML
, where quotes were being removed automatically. Addressed this issue in 1af7829 The reason for this behavior inparseHTML
is unclear, so further investigation may be required.Testing Done
All existing tests pass. Added a new test specifically for
font-family
values with both spaces and numbers.Verification Steps
Run the test suite to confirm no regressions.
Verify that fonts with spaces and numbers in their names, like "Exo 2", are correctly parsed without removing quotes.
Additional Notes
This pull request is related to #4545
Checklist
Related Issues