Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-family extension: Prevent removal of quotes in parseHTML #5828

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

SanderLeenders
Copy link
Contributor

Changes Overview

Font-family extension: Prevent removal of quotes in parseHTML

Removing quotes in font-family parsing can result in invalid HTML when using font names that contain both spaces and numbers (e.g., "Exo 2").

Implementation Approach

Initially attempted to add quotes in renderHTML, but realized the issue originated in parseHTML, where quotes were being removed automatically. Addressed this issue in 1af7829 The reason for this behavior in parseHTML is unclear, so further investigation may be required.

Testing Done

All existing tests pass. Added a new test specifically for font-family values with both spaces and numbers.

Verification Steps

Run the test suite to confirm no regressions.
Verify that fonts with spaces and numbers in their names, like "Exo 2", are correctly parsed without removing quotes.

Additional Notes

This pull request is related to #4545

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Sander added 2 commits November 12, 2024 21:53
…bers

Removed the quote removal step in font-family parsing to support fonts that contain both spaces and numbers, such as "Exo 2", which require quotes for proper recognition.
…lude both spaces and numbers, such as "Exo 2".
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 4ec1f9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit c9a9196
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6739f5d169ac74000863d05c
😎 Deploy Preview https://deploy-preview-5828--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SanderLeenders
Copy link
Contributor Author

@nperez0111 As requested, I’ve made the updates—hopefully this meets your expectations.

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all of the details and getting this fixed @SanderLeenders!

@nperez0111 nperez0111 merged commit 38abfdf into ueberdosis:develop Nov 17, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants