fix(link): add backwards compat by deprecating validate and using isAllowedUri instead #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowedUri instead
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guarmo
approved these changes
Nov 7, 2024
1 task
rajsite
added a commit
to ni/nimble
that referenced
this pull request
Dec 4, 2024
# Pull Request ## 🤨 Rationale Updates dependencies manually to address build issues revealed by #2482 #2481 #2480. Found that just updating dependencies by rebuilding the lock fails the build which means the [repo is in a bad state](#1479 (comment)) and that should be addressed quickly. ## 👩💻 Implementation - Update major deps and rebuild lock - Found that the now [deprecated tiptap link validate](https://tiptap.dev/docs/editor/extensions/marks/link#validate-deprecated) function is expected to still function with [backwards compat](ueberdosis/tiptap#5812) however there seems to be a regression as it [fails our build by allowing autolinking of unexpected protocols](https://github.com/ni/nimble/actions/runs/12110590706/job/33761233944#step:17:613). - Switched from tiptap link validate to [shouldAutoLink](https://tiptap.dev/docs/editor/extensions/marks/link#shouldautolink) as described by docs. That seems to not fail the build. - Pushed the min semver range version up for all the tiptap / prosemirror packages as otherwise it seems to[ fail build when type checking libraries](ueberdosis/tiptap#5867). **NOTE**: It seems to be transitive dependency type issues that will fail builds, I think it's possible that minimal upgrades done by renovate may hit issues in app updates. If an app adopting latest these changes fails to build it may need to rebuild the lock files in a clean workspace to align transitive deps on latest versions and avoid library type check issues. - Updates to [prettier 3.4](https://prettier.io/blog/2024/11/26/3.4.0.html) resulting in lots of changes. ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
As a follow up to this: #5808
Adds
isAllowedUriwhich handles XSS protections,deprecates
validatein favor of the newshouldAutoLinkwhich is a better name for what it doesImplementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues